fix(fs): prevent ENOENT on subst drive root paths like "M:\\" on Windows #58989
+131
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58989 +/- ##
==========================================
- Coverage 90.14% 90.05% -0.09%
==========================================
Files 630 645 +15
Lines 186784 189130 +2346
Branches 36653 37089 +436
==========================================
+ Hits 168377 170327 +1950
- Misses 11205 11511 +306
- Partials 7202 7292 +90
🚀 New features to boost your workflow:
|
mag123c
force-pushed
the
fix-windows-subst-drive-issue
branch
2 times, most recently
from
1474ed1 to
fcaee03
Compare
|
I've force-pushed a fix (e.g. lint issue resolved). |
When using fs.readdir() or fs.readdirSync() on subst drive root paths such as M:\, Node.js was incorrectly adding a second backslash, resulting in M:\\, which caused ENOENT errors on Windows. This patch adds a safeguard to avoid appending a backslash if the path already represents a drive root, including both standard (e.g. C:\) and namespaced (e.g. \\?\C:\) formats. Fixes: nodejs#58970
mag123c
force-pushed
the
fix-windows-subst-drive-issue
branch
from
fcaee03 to
c97462b
Compare
|
I apologize - the format-cpp check failed again. I've pushed another fix to address the formatting issue. This appears to be an unrelated test, as:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where
fs.readdirSync('M:\\')and related callswould fail with an
ENOENTerror on Windows when using subst drive roots.Previously, Node.js added a trailing backslash (
\) even when the input pathwas already a drive root (e.g.,
M:\or\\?\M:\), resulting in invalid pathslike
M:\\\. This patch introduces a check to detect standard and namespaceddrive root formats and avoid appending an extra slash in those cases.
The fix is Windows-specific and scoped only to the logic within
fs.readdir.Changes
src/node_file.ccto detect and skip appending\for drive root pathstest/parallel/test-fs-readdir-windows-subst.jssubst-like paths with and without trailing slashesENOENTerror is thrown for valid drive rootsContext
Fixes: #58970