-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
test: move http proxy tests to test/client-proxy #58950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
const child = spawn(...args); | ||
child.stderr.setEncoding('utf8'); | ||
child.stderr.on('data', (data) => { | ||
console.error('[STDERR]', data); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These logs are added for debugging, similar to what the test/common/inspector-helper.js does, otherwise the tests can be difficult to debug when they fail with no output from the child and I found myself constantly adding these logs. Would be good to have them if they ever fail/flake in the CI, otherwise it'd be a pain to add them back and forth.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58950 +/- ##
==========================================
- Coverage 90.06% 90.05% -0.01%
==========================================
Files 645 645
Lines 189130 189130
Branches 37094 37090 -4
==========================================
- Hits 170339 170325 -14
- Misses 11511 11513 +2
- Partials 7280 7292 +12 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RSLGTM
b282d6a
to
eacc14e
Compare
Rewrite to ESM to use TLA. Also add a test to make sure case precedence is honored. Refs: https://about.gitlab.com/blog/we-need-to-talk-no-proxy
1181314
to
ff6ba64
Compare
Move them to a separate directory for the ease of running them. And Rewrite to ESM to use TLA.
Also add a test to make sure case precedence is honored.
Refs: https://about.gitlab.com/blog/we-need-to-talk-no-proxy
Split off from the WIP that supports http/https.request
Refs: #57872