-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
test: add fs.rmSync regression test for Unicode filename crash on Windows #58884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58884 +/- ##
==========================================
+ Coverage 90.07% 90.10% +0.02%
==========================================
Files 640 640
Lines 188262 188493 +231
Branches 36912 36966 +54
==========================================
+ Hits 169580 169842 +262
+ Misses 11399 11358 -41
- Partials 7283 7293 +10 🚀 New features to boost your workflow:
|
Failed to start CI⚠ No approving reviews found ✘ Refusing to run CI on potentially unsafe PRhttps://github.com/nodejs/node/actions/runs/15994275556 |
Hey @nabeel378, thanks for the effort. From what I understand, this test will fail with the current Node.js implementation - it will not throw an error, and asserting |
HI @StefanStojanovic, |
Sorry for the late response. Anyway, this cannot be landed as is, as all future CI runs would fail because this test (which fails). What would be acceptable is the change that fixes the problem showcased in this test, together with the test to prevent any future regressions. |
Yes, you are right, i am working on it to solved these issue |
Adds a regression test for a Windows-specific bug where
fs.rmSync('速')
crashes without throwing, observed in Node.js v23.3.0.