Skip to content

meta: add ability to block issues #58796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

meta: add ability to block issues #58796

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ See [details on our policy on Code of Conduct](./doc/contributing/code-of-conduc
* [Discussing non-technical topics](./doc/contributing/issues.md#discussing-non-technical-topics)
* [Submitting a Bug Report](./doc/contributing/issues.md#submitting-a-bug-report)
* [Triaging a Bug Report](./doc/contributing/issues.md#triaging-a-bug-report)
* [Blocking Issues](./doc/contributing/issues.md#blocking-issues)

## [Pull Requests](./doc/contributing/pull-requests.md)

Expand Down
8 changes: 8 additions & 0 deletions doc/contributing/issues.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
* [Discussing non-technical topics](#discussing-non-technical-topics)
* [Submitting a bug report](#submitting-a-bug-report)
* [Triaging a bug report](#triaging-a-bug-report)
* [Blocking Issues](#blocking-issues)

## Asking for general help

Expand Down Expand Up @@ -72,5 +73,12 @@ When triagging issues and PRs:
dismissive from the point of view of the reporter/author.
Always try to communicate the reason for closing the issue/PR.

## Blocking Issues

Collaborators have the ability to block issues from getting implemented and landed into
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The wording here is problematic. We cannot block anything from being implemented. We block PRs from being merged. None of us have the right or ability to block anyone from implementing anything.

the project by commenting and explicitly including "-1" in the comment.
When doing so, explain why you believe the pull request should not land along with
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part is already covered adequately elsewhere in the guidelines.

an explanation of what may be an acceptable alternative course, if any.

[Node.js help repository]: https://github.com/nodejs/help/issues
[Technical Steering Committee (TSC) repository]: https://github.com/nodejs/TSC/issues
Loading