doc: add instructions to only sign a release #5876
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doc/releases.md
Outdated
Contributor
There was a problem hiding this comment.
nit: may be reasons other than forgetting for signing after the fact. Perhaps it should just note the option and ability to sign after promoting?
Contributor
|
LGTM if you address the nit |
Contributor
|
LGTM |
1 similar comment
Member
|
LGTM |
Fishrock123
force-pushed
the
release-sign-only
branch
from
abf7d93 to
55cbd4b
Compare
Contributor
Author
|
@thealphanerd updated, ptal. |
Contributor
|
LGTM |
jasnell
pushed a commit
that referenced
this pull request
Mar 25, 2016
PR-URL: #5876 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Member
|
Landed in be68b68 |
evanlucas
pushed a commit
that referenced
this pull request
Mar 30, 2016
PR-URL: #5876 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 30, 2016
PR-URL: #5876 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 30, 2016
PR-URL: #5876 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
evanlucas
pushed a commit
that referenced
this pull request
Mar 31, 2016
PR-URL: #5876 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Affected core subsystem(s)
doc
Description of change
I didn't know this existed since it wasn't documented, but after some digging into the script itself this totally saved me today after I did release things out-of-order. 😓