Skip to content

test_runner: prefer Atomics primordials #58716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 17, 2025

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Jun 15, 2025

Extracted from #58577

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Jun 15, 2025
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jun 15, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 15, 2025
@nodejs-github-bot
Copy link
Collaborator

Copy link

codecov bot commented Jun 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.16%. Comparing base (462c741) to head (ef2e084).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #58716   +/-   ##
=======================================
  Coverage   90.15%   90.16%           
=======================================
  Files         639      639           
  Lines      188201   188195    -6     
  Branches    36915    36916    +1     
=======================================
+ Hits       169675   169679    +4     
+ Misses      11274    11273    -1     
+ Partials     7252     7243    -9     
Files with missing lines Coverage Δ
lib/internal/test_runner/mock/loader.js 95.58% <100.00%> (-0.09%) ⬇️
lib/internal/test_runner/mock/mock.js 99.27% <100.00%> (-0.01%) ⬇️

... and 33 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@LiviaMedeiros
Copy link
Member

/cc @Renegade334 just in case.

@Renegade334
Copy link
Contributor

Thanks all.

PR-URL: nodejs#58716
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
@aduh95 aduh95 force-pushed the test_runner-atomics-primordials branch from 7bba030 to ef2e084 Compare June 17, 2025 14:54
@aduh95
Copy link
Contributor Author

aduh95 commented Jun 17, 2025

Landed in ef2e084

@aduh95 aduh95 merged commit ef2e084 into nodejs:main Jun 17, 2025
19 checks passed
@aduh95 aduh95 deleted the test_runner-atomics-primordials branch June 17, 2025 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants