Skip to content

http2: fix DEP0194 message #58669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 11, 2025
Merged

http2: fix DEP0194 message #58669

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/internal/http2/core.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -752,7 +752,7 @@ function onGoawayData(code, lastStreamID, buf) {

// TODO(aduh95): remove this in future semver-major
const deprecateWeight = deprecateProperty('weight',
'Priority signaling has been deprecated as of RFC 1993.',
'Priority signaling has been deprecated as of RFC 9113.',
'DEP0194');

// When a ClientHttp2Session is first created, the socket may not yet be
Expand Down Expand Up @@ -2476,7 +2476,7 @@ class Http2Stream extends Duplex {
Http2Stream.prototype.priority = deprecate(function priority(options) {
if (this.destroyed)
throw new ERR_HTTP2_INVALID_STREAM();
}, 'http2Stream.priority is longer supported after priority signalling was deprecated in RFC 1993', 'DEP0194');
}, 'http2Stream.priority is longer supported after priority signalling was deprecated in RFC 9113', 'DEP0194');

function callTimeout(self, session) {
// If the session is destroyed, this should never actually be invoked,
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-http2-client-priority-before-connect.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ const h2 = require('http2');

common.expectWarning(
'DeprecationWarning',
'http2Stream.priority is longer supported after priority signalling was deprecated in RFC 1993',
'http2Stream.priority is longer supported after priority signalling was deprecated in RFC 9113',
'DEP0194');

const server = h2.createServer();
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-http2-client-set-priority.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ const http2 = require('http2');

common.expectWarning(
'DeprecationWarning',
'Priority signaling has been deprecated as of RFC 1993.',
'Priority signaling has been deprecated as of RFC 9113.',
'DEP0194');

const checkWeight = (actual, expect) => {
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-http2-priority-cycle-.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ const Countdown = require('../common/countdown');

common.expectWarning(
'DeprecationWarning',
'http2Stream.priority is longer supported after priority signalling was deprecated in RFC 1993',
'http2Stream.priority is longer supported after priority signalling was deprecated in RFC 9113',
'DEP0194');

const server = http2.createServer();
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-http2-priority-event.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ const h2 = require('http2');

common.expectWarning(
'DeprecationWarning',
'http2Stream.priority is longer supported after priority signalling was deprecated in RFC 1993',
'http2Stream.priority is longer supported after priority signalling was deprecated in RFC 9113',
'DEP0194');

const server = h2.createServer();
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-http2-server-stream-session-destroy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ const h2 = require('http2');

common.expectWarning(
'DeprecationWarning',
'http2Stream.priority is longer supported after priority signalling was deprecated in RFC 1993',
'http2Stream.priority is longer supported after priority signalling was deprecated in RFC 9113',
'DEP0194');

const server = h2.createServer();
Expand Down
Loading