Skip to content

win,tools: use Azure Trusted Signing (v20 backport) #58659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
43 commits
Select commit Hold shift + click to select a range
1b37ba8
deps: update llhttp to 9.3.0
indutny May 7, 2025
c0792dd
doc: add ambassaor message
bmuenzenmeyer Mar 23, 2025
cc0f618
doc: fix misaligned options in vm.compileFunction()
hkleungai May 5, 2025
f631dc5
doc: add missing options.signal to readlinePromises.createInterface()
hkleungai May 3, 2025
915e537
doc: fix typo of file `zlib.md`
samuel871211 May 3, 2025
7b90de7
doc: fix `AsyncLocalStorage` example response changes after node v18
ntedgi Apr 24, 2025
161cca4
doc: add dario-piotrowicz to collaborators
dario-piotrowicz May 1, 2025
86229cb
test: prevent extraneous HOSTNAME substitution in test-runner-output
Renegade334 May 1, 2025
f339d57
doc: fix env variable name in `util.styleText`
aduh95 May 1, 2025
29a8a1b
doc: add returns for https.get
Juneezee Apr 29, 2025
f86779d
doc: correct deprecation type of `assert.CallTracker`
Renegade334 Apr 24, 2025
83ef9fe
deps: update icu to 77.1
nodejs-github-bot Mar 16, 2025
e0cf31c
deps: update timezone to 2025b
nodejs-github-bot Apr 16, 2025
ebb59be
doc: add missing v0.x changelog entries
aduh95 Apr 8, 2025
df0ba1b
doc: stabilize util.styleText
RafaelGSS Dec 17, 2024
64faac6
http: be more generational GC friendly
ywave620 Jan 31, 2025
a96eab5
src: fix -Wunreachable-code-return in node_sea
codebytere Apr 23, 2025
c04f30c
src: allow embedder customization of OOMErrorHandler
codebytere Mar 7, 2025
8c77f73
http: correctly translate HTTP method
ShogunPanda Apr 26, 2024
703f4fa
test: deflake test-http2-options-max-headers-block-length
lpinca Apr 24, 2025
6a2258b
test: force GC in test-file-write-stream4
lpinca Apr 20, 2025
6374ba2
os: fix netmask format check condition in getCIDR function
HBSPS Apr 20, 2025
6f33311
http2: fix graceful session close
pandeykushagra51 Apr 19, 2025
cffb5cc
deps: update simdutf to 6.4.2
nodejs-github-bot Apr 15, 2025
75a49d8
tools: edit create-release-proposal workflow to handle pr body length
elvessilvavieira Apr 14, 2025
8ac34ba
tools: remove unused `osx-pkg-postinstall.sh`
aduh95 Apr 12, 2025
50954f9
doc: update position type to integer | null in fs
y-hsgw Apr 6, 2025
5480c73
src: remove unused variable in crypto_x509.cc
targos Apr 5, 2025
39cf617
http2: skip writeHead if stream is closed
islandryu Apr 4, 2025
0a13eb2
doc: clarify `unhandledRejection` events behaviors in process doc
dario-piotrowicz Apr 2, 2025
4f265b1
doc: improved fetch docs
lifeisfoo Apr 2, 2025
97497a5
doc: document REPL custom eval arguments
dario-piotrowicz Apr 1, 2025
375d3c1
doc: add gurgunday as triager
gurgunday Mar 29, 2025
4959820
doc: mention reports should align with Node.js CoC
RafaelGSS Mar 26, 2025
76577cd
test: mark test-without-async-context-frame flaky on windows
jasnell Jan 24, 2025
4592bd3
typings: fix `ImportModuleDynamicallyCallback` return type
legendecas Feb 21, 2025
f96762c
deps: V8: cherry-pick third_party/zlib@646b7f569718
zmodem Apr 22, 2025
2060738
deps: V8: cherry-pick 182d9c05e78b
caseq Aug 17, 2023
b1aca24
deps: V8: cherry-pick 1a3ecc2483b2
targos Sep 13, 2023
7da8602
test,crypto: update WebCryptoAPI WPT
panva Aug 29, 2024
a029c66
crypto: allow length=0 for HKDF and PBKDF2 in SubtleCrypto.deriveBits
panva Nov 17, 2024
0d24452
test: update WPT for WebCryptoAPI to edd42c005c
nodejs-github-bot Mar 9, 2025
54a8c87
win,tools: use Azure Trusted Signing
StefanStojanovic Jun 5, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -317,6 +317,8 @@ For information about the governance of the Node.js project, see
**Kohei Ueno** <<kohei.ueno119@gmail.com>> (he/him)
* [daeyeon](https://github.com/daeyeon) -
**Daeyeon Jeong** <<daeyeon.dev@gmail.com>> (he/him)
* [dario-piotrowicz](https://github.com/dario-piotrowicz) -
**Dario Piotrowicz** <<dario.piotrowicz@gmail.com>> (he/him)
* [debadree25](https://github.com/debadree25) -
**Debadree Chatterjee** <<debadree333@gmail.com>> (he/him)
* [deokjinkim](https://github.com/deokjinkim) -
Expand Down Expand Up @@ -745,6 +747,8 @@ maintaining the Node.js project.
**Feng Yu** <<F3n67u@outlook.com>> (he/him)
* [gireeshpunathil](https://github.com/gireeshpunathil) -
**Gireesh Punathil** <<gpunathi@in.ibm.com>> (he/him)
* [gurgunday](https://github.com/gurgunday) -
**Gürgün Dayıoğlu** <<hey@gurgun.day>>
* [iam-frankqiu](https://github.com/iam-frankqiu) -
**Frank Qiu** <<iam.frankqiu@gmail.com>> (he/him)
* [KevinEady](https://github.com/KevinEady) -
Expand Down
33 changes: 33 additions & 0 deletions SECURITY.md
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,39 @@ Here is the security disclosure policy for Node.js
possible; however, we must follow the release process above to ensure that we
handle disclosure consistently.

## Code of Conduct and Vulnerability Reporting Guidelines

When reporting security vulnerabilities, reporters must adhere to the following guidelines:

1. **Code of Conduct Compliance**: All security reports must comply with our
[Code of Conduct](CODE_OF_CONDUCT.md). Reports that violate our code of conduct
will not be considered and may result in being banned from future participation.

2. **No Harmful Actions**: Security research and vulnerability reporting must not:
* Cause damage to running systems or production environments.
* Disrupt Node.js development or infrastructure.
* Affect other users' applications or systems.
* Include actual exploits that could harm users.
* Involve social engineering or phishing attempts.

3. **Responsible Testing**: When testing potential vulnerabilities:
* Use isolated, controlled environments.
* Do not test on production systems.
* Do not attempt to access or modify other users' data.
* Immediately stop testing if unauthorized access is gained accidentally.

4. **Report Quality**
* Provide clear, detailed steps to reproduce the vulnerability.
* Include only the minimum proof of concept required to demonstrate the issue.
* Remove any malicious payloads or components that could cause harm.

Failure to follow these guidelines may result in:

* Rejection of the vulnerability report.
* Forfeiture of any potential bug bounty.
* Temporary or permanent ban from the bug bounty program.
* Legal action in cases of malicious intent.

## The Node.js threat model

In the Node.js threat model, there are trusted elements such as the
Expand Down
2 changes: 1 addition & 1 deletion common.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@

# Reset this number to 0 on major V8 upgrades.
# Increment by one for each non-official patch applied to deps/v8.
'v8_embedder_string': '-node.26',
'v8_embedder_string': '-node.29',

##### V8 defaults for Node.js #####

Expand Down
2 changes: 1 addition & 1 deletion deps/icu-small/LICENSE
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ UNICODE LICENSE V3

COPYRIGHT AND PERMISSION NOTICE

Copyright © 2016-2024 Unicode, Inc.
Copyright © 2016-2025 Unicode, Inc.

NOTICE TO USER: Carefully read the following legal agreement. BY
DOWNLOADING, INSTALLING, COPYING OR OTHERWISE USING DATA FILES, AND/OR
Expand Down
4 changes: 2 additions & 2 deletions deps/icu-small/README-FULL-ICU.txt
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
ICU sources - auto generated by shrink-icu-src.py

This directory contains the ICU subset used by --with-intl=full-icu
It is a strict subset of ICU 76 source files with the following exception(s):
* deps/icu-small/source/data/in/icudt76l.dat.bz2 : compressed data file
It is a strict subset of ICU 77 source files with the following exception(s):
* deps/icu-small/source/data/in/icudt77l.dat.bz2 : compressed data file


To rebuild this directory, see ../../tools/icu/README.md
Expand Down
55 changes: 34 additions & 21 deletions deps/icu-small/source/common/brkiter.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ BreakIterator::buildInstance(const Locale& loc, const char *type, UErrorCode &st
{
char fnbuff[256];
char ext[4]={'\0'};
CharString actualLocale;
CharString actual;
int32_t size;
const char16_t* brkfname = nullptr;
UResourceBundle brkRulesStack;
Expand Down Expand Up @@ -94,7 +94,7 @@ BreakIterator::buildInstance(const Locale& loc, const char *type, UErrorCode &st

// Use the string if we found it
if (U_SUCCESS(status) && brkfname) {
actualLocale.append(ures_getLocaleInternal(brkName, &status), -1, status);
actual.append(ures_getLocaleInternal(brkName, &status), -1, status);

char16_t* extStart=u_strchr(brkfname, 0x002e);
int len = 0;
Expand Down Expand Up @@ -123,10 +123,9 @@ BreakIterator::buildInstance(const Locale& loc, const char *type, UErrorCode &st
if (U_SUCCESS(status) && result != nullptr) {
U_LOCALE_BASED(locBased, *(BreakIterator*)result);

locBased.setLocaleIDs(ures_getLocaleByType(b, ULOC_VALID_LOCALE, &status),
actualLocale.data());
uprv_strncpy(result->requestLocale, loc.getName(), ULOC_FULLNAME_CAPACITY);
result->requestLocale[ULOC_FULLNAME_CAPACITY-1] = 0; // always terminate
locBased.setLocaleIDs(ures_getLocaleByType(b, ULOC_VALID_LOCALE, &status),
actual.data(), status);
LocaleBased::setLocaleID(loc.getName(), result->requestLocale, status);
}

ures_close(b);
Expand Down Expand Up @@ -206,26 +205,32 @@ BreakIterator::getAvailableLocales(int32_t& count)

BreakIterator::BreakIterator()
{
*validLocale = *actualLocale = *requestLocale = 0;
}

BreakIterator::BreakIterator(const BreakIterator &other) : UObject(other) {
uprv_strncpy(actualLocale, other.actualLocale, sizeof(actualLocale));
uprv_strncpy(validLocale, other.validLocale, sizeof(validLocale));
uprv_strncpy(requestLocale, other.requestLocale, sizeof(requestLocale));
UErrorCode status = U_ZERO_ERROR;
U_LOCALE_BASED(locBased, *this);
locBased.setLocaleIDs(other.validLocale, other.actualLocale, status);
LocaleBased::setLocaleID(other.requestLocale, requestLocale, status);
U_ASSERT(U_SUCCESS(status));
}

BreakIterator &BreakIterator::operator =(const BreakIterator &other) {
if (this != &other) {
uprv_strncpy(actualLocale, other.actualLocale, sizeof(actualLocale));
uprv_strncpy(validLocale, other.validLocale, sizeof(validLocale));
uprv_strncpy(requestLocale, other.requestLocale, sizeof(requestLocale));
UErrorCode status = U_ZERO_ERROR;
U_LOCALE_BASED(locBased, *this);
locBased.setLocaleIDs(other.validLocale, other.actualLocale, status);
LocaleBased::setLocaleID(other.requestLocale, requestLocale, status);
U_ASSERT(U_SUCCESS(status));
}
return *this;
}

BreakIterator::~BreakIterator()
{
delete validLocale;
delete actualLocale;
delete requestLocale;
}

// ------------------------------------------
Expand Down Expand Up @@ -394,7 +399,7 @@ BreakIterator::createInstance(const Locale& loc, int32_t kind, UErrorCode& statu
// revisit this in ICU 3.0 and clean it up/fix it/remove it.
if (U_SUCCESS(status) && (result != nullptr) && *actualLoc.getName() != 0) {
U_LOCALE_BASED(locBased, *result);
locBased.setLocaleIDs(actualLoc.getName(), actualLoc.getName());
locBased.setLocaleIDs(actualLoc.getName(), actualLoc.getName(), status);
}
return result;
}
Expand Down Expand Up @@ -488,6 +493,7 @@ BreakIterator::makeInstance(const Locale& loc, int32_t kind, UErrorCode& status)
}

if (U_FAILURE(status)) {
delete result;
return nullptr;
}

Expand All @@ -496,20 +502,25 @@ BreakIterator::makeInstance(const Locale& loc, int32_t kind, UErrorCode& status)

Locale
BreakIterator::getLocale(ULocDataLocaleType type, UErrorCode& status) const {
if (U_FAILURE(status)) {
return Locale::getRoot();
}
if (type == ULOC_REQUESTED_LOCALE) {
return {requestLocale};
return requestLocale == nullptr ?
Locale::getRoot() : Locale(requestLocale->data());
}
U_LOCALE_BASED(locBased, *this);
return locBased.getLocale(type, status);
return LocaleBased::getLocale(validLocale, actualLocale, type, status);
}

const char *
BreakIterator::getLocaleID(ULocDataLocaleType type, UErrorCode& status) const {
if (U_FAILURE(status)) {
return nullptr;
}
if (type == ULOC_REQUESTED_LOCALE) {
return requestLocale;
return requestLocale == nullptr ? "" : requestLocale->data();
}
U_LOCALE_BASED(locBased, *this);
return locBased.getLocaleID(type, status);
return LocaleBased::getLocaleID(validLocale, actualLocale, type, status);
}


Expand All @@ -536,8 +547,10 @@ int32_t BreakIterator::getRuleStatusVec(int32_t *fillInVec, int32_t capacity, UE
}

BreakIterator::BreakIterator (const Locale& valid, const Locale& actual) {
UErrorCode status = U_ZERO_ERROR;
U_LOCALE_BASED(locBased, (*this));
locBased.setLocaleIDs(valid, actual);
locBased.setLocaleIDs(valid.getName(), actual.getName(), status);
U_ASSERT(U_SUCCESS(status));
}

U_NAMESPACE_END
Expand Down
11 changes: 10 additions & 1 deletion deps/icu-small/source/common/charstr.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,15 @@ CharString &CharString::copyFrom(const CharString &s, UErrorCode &errorCode) {
return *this;
}

CharString &CharString::copyFrom(StringPiece s, UErrorCode &errorCode) {
if (U_FAILURE(errorCode)) {
return *this;
}
len = 0;
append(s, errorCode);
return *this;
}

int32_t CharString::lastIndexOf(char c) const {
for(int32_t i=len; i>0;) {
if(buffer[--i]==c) {
Expand Down Expand Up @@ -143,7 +152,7 @@ CharString &CharString::append(const char *s, int32_t sLength, UErrorCode &error
return *this;
}

CharString &CharString::appendNumber(int32_t number, UErrorCode &status) {
CharString &CharString::appendNumber(int64_t number, UErrorCode &status) {
if (number < 0) {
this->append('-', status);
if (U_FAILURE(status)) {
Expand Down
3 changes: 2 additions & 1 deletion deps/icu-small/source/common/charstr.h
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@ class U_COMMON_API CharString : public UMemory {
* use a UErrorCode where memory allocations might be needed.
*/
CharString &copyFrom(const CharString &other, UErrorCode &errorCode);
CharString &copyFrom(StringPiece s, UErrorCode &errorCode);

UBool isEmpty() const { return len==0; }
int32_t length() const { return len; }
Expand Down Expand Up @@ -135,7 +136,7 @@ class U_COMMON_API CharString : public UMemory {
}
CharString &append(const char *s, int32_t sLength, UErrorCode &status);

CharString &appendNumber(int32_t number, UErrorCode &status);
CharString &appendNumber(int64_t number, UErrorCode &status);

/**
* Returns a writable buffer for appending and writes the buffer's capacity to
Expand Down
Loading
Loading