tools: improve release proposal linter #58647
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
aduh95
commented
Jun 9, 2025
aduh95
commented
- Add an annotation on the line that's causing the linter to fail (if applicable)
- Do not exit the program on the first error (in case there are several errors)
- Improve some error messages
|
Review requested:
|
|
I did test it with https://github.com/nodejs/node/actions/runs/15537367744 |
aduh95
added
the
author ready
RafaelGSS
approved these changes
Jun 10, 2025
aduh95
added
the
commit-queue
bnb
approved these changes
Jun 10, 2025
meixg
approved these changes
Jun 11, 2025
nodejs-github-bot
removed
the
commit-queue
|
Landed in 3a7f8ef |
targos
pushed a commit
that referenced
this pull request
Jun 16, 2025
PR-URL: #58647 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Tierney Cyren <hello@bnb.im> Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
This was referenced Jun 23, 2025
aduh95
added a commit
that referenced
this pull request
Jul 21, 2025
PR-URL: #58647 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Tierney Cyren <hello@bnb.im> Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
aduh95
added a commit
that referenced
this pull request
Jul 24, 2025
PR-URL: #58647 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Tierney Cyren <hello@bnb.im> Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.