module: runtime deprecate require.extensions#58642
Draft
marco-ippolito wants to merge 1 commit intonodejs:mainfrom
Draft
module: runtime deprecate require.extensions#58642marco-ippolito wants to merge 1 commit intonodejs:mainfrom
marco-ippolito wants to merge 1 commit intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
module
marco-ippolito
added
deprecations
Member
|
We should run citgm on this. |
anonrig
approved these changes
Jun 9, 2025
legendecas
reviewed
Jun 9, 2025
| Type: Documentation-only | ||
| Type: Runtime | ||
|
|
||
| The [`require.extensions`][] property is deprecated. |
Member
There was a problem hiding this comment.
I think an alternative, like module.register or module.registerHooks, should be recommended, and be stable, before runtime deprecating this.
Member
There was a problem hiding this comment.
registerHooks, not register. The latter should go away once the former is ready. And registerHooks is a more appropriate replacement for extensions as both are sync.
Member
Author
There was a problem hiding this comment.
it would actually need an api that returns all the registered hooks + registerHooks
mcollina
requested changes
Jun 9, 2025
Member
mcollina
left a comment
mcollina
left a comment
There was a problem hiding this comment.
I don't think we can do this before registerHooks() is stable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm opening this as draft PR to discuss if we should do runtime deprecate require.extensions.
It has been deprecated since v0.10.6.
This might have a large impact.
It's causing some issues for type stripping nodejs/typescript#37