Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix zlib pseudo multi member failure #5863

Closed
wants to merge 2 commits into from
Closed

Fix zlib pseudo multi member failure #5863

wants to merge 2 commits into from

Commits on Mar 23, 2016

  1. test: add tests for reproducing nodejs#5852 

    Add test files that reliably reproduce nodejs#5852. The gzipped file
in test/fixtures/pseudo-multimember-gzip.gz contains the gzip
magic bytes exactly at the position that node encounters after having
read a single block, leading it to believe that a new data
member is starting.
    @addaleax
    addaleax committed Mar 23, 2016
    Configuration menu
    Copy the full SHA
    2dd5945 View commit details
    Browse the repository at this point in the history

  2. zlib: Fix handling of gzip magic bytes mid-file 

    Only treat the gzip magic bytes, when encountered within the file
after reading a single block, as the start of a new member when
the previous member has ended.

Fixes: nodejs#5852
    @addaleax
    addaleax committed Mar 23, 2016
    Configuration menu
    Copy the full SHA
    1b2900f View commit details
    Browse the repository at this point in the history