test: close FileHandle objects in tests explicitly #58615
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
This comment was marked as outdated.
This comment was marked as outdated.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58615 +/- ##
==========================================
+ Coverage 90.20% 90.22% +0.01%
==========================================
Files 636 636
Lines 187718 187718
Branches 36855 36870 +15
==========================================
+ Hits 169331 169360 +29
+ Misses 11153 11123 -30
- Partials 7234 7235 +1 🚀 New features to boost your workflow:
|
LiviaMedeiros
approved these changes
Jun 7, 2025
jasnell
added
the
author ready
lpinca
approved these changes
Jun 7, 2025
jasnell
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 2eeb65f |
seriousme
pushed a commit
to seriousme/node
that referenced
this pull request
Jun 10, 2025
PR-URL: nodejs#58615 Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jun 16, 2025
PR-URL: #58615 Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separated out from #58536. Specifically not using
usingso the test changes can be backported.This is in preparation for moving the close-filehandle-on-gc to EOL.