http2: add diagnostics channel 'http2.server.stream.close' #58602
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Darshan Sen <raisinten@gmail.com>
|
Review requested:
|
nodejs-github-bot
added
http2
lpinca
approved these changes
Jun 6, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58602 +/- ##
========================================
Coverage 90.19% 90.20%
========================================
Files 635 636 +1
Lines 187495 187702 +207
Branches 36819 36850 +31
========================================
+ Hits 169116 169309 +193
+ Misses 11158 11152 -6
- Partials 7221 7241 +20
🚀 New features to boost your workflow:
|
bjohansebas
approved these changes
Jun 7, 2025
RaisinTen
added
author ready
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/58602 ✔ Done loading data for nodejs/node/pull/58602 ----------------------------------- PR info ------------------------------------ Title http2: add diagnostics channel 'http2.server.stream.close' (#58602) Author Darshan Sen <raisinten@gmail.com> (@RaisinTen) Branch RaisinTen:http2-add-diagnostics-channel-http2.server.stream.close -> nodejs:main Labels http2, author ready, needs-ci Commits 1 - http2: add diagnostics channel 'http2.server.stream.close' Committers 1 - Darshan Sen <raisinten@gmail.com> PR-URL: https://github.com/nodejs/node/pull/58602 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/58602 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Fri, 06 Jun 2025 13:56:35 GMT ✔ Approvals: 1 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/58602#pullrequestreview-2905093741 ✘ This PR needs to wait 103 more hours to land (or 0 hours if there is one more approval) ✔ Last GitHub CI successful ℹ Last Full PR CI on 2025-06-06T13:57:45Z: https://ci.nodejs.org/job/node-test-pull-request/67298/ - Querying data for job/node-test-pull-request/67298/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/15527848748 |
Qard
approved these changes
Jun 11, 2025
RaisinTen
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 85e8cc6 |
RaisinTen
deleted the
http2-add-diagnostics-channel-http2.server.stream.close
branch
targos
pushed a commit
that referenced
this pull request
Jun 16, 2025
Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #58602 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.