-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
build: fix android build #58574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
build: fix android build #58574
Conversation
Review requested:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and I'll take your word for it that it builds. The commit log should be something like build: fix android build
with a Fixes: https://github.com/nodejs/node/issues/58505
line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since both cases are now identical, can we remove the condition and move the sources to the main sources
array (starting at line 1445)
I have updated the commit message and included the build process. Please note that there might still be build errors on Apple Silicon processors. |
Still errors... |
This commit fixes a bug in the V8 engine as detailed in the linked issue.
All tests pass locally.
Fixes: #58505
Info
To build Node.js on a Mac with Apple Silicon (& Android NDK), you need to switch to the Rosetta architecture (x86_64) before starting the build process. If you run into issues related to
LLONG_MAX
fromlimits.h
(not included), the only workaround is to define LLONG_MAX
manually like this:deps/uv/src/unix/linux.c
Build
Make sure you've installed
Android NDK
.python3 android-configure $ANDROID_NDK_HOME 24 arm64
make -j2