Skip to content

http: remove unused functions and add todos #58143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 9, 2025
Merged

http: remove unused functions and add todos #58143

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 6 additions & 28 deletions src/node_http_parser.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -563,15 +563,15 @@ class Parser : public AsyncWrap, public StreamListener {
new Parser(binding_data, args.This());
}


// TODO(@anonrig): Add V8 Fast API
static void Close(const FunctionCallbackInfo<Value>& args) {
Parser* parser;
ASSIGN_OR_RETURN_UNWRAP(&parser, args.This());

delete parser;
}


// TODO(@anonrig): Add V8 Fast API
static void Free(const FunctionCallbackInfo<Value>& args) {
Parser* parser;
ASSIGN_OR_RETURN_UNWRAP(&parser, args.This());
Expand All @@ -582,6 +582,7 @@ class Parser : public AsyncWrap, public StreamListener {
parser->EmitDestroy();
}

// TODO(@anonrig): Add V8 Fast API
static void Remove(const FunctionCallbackInfo<Value>& args) {
Parser* parser;
ASSIGN_OR_RETURN_UNWRAP(&parser, args.This());
Expand Down Expand Up @@ -694,6 +695,7 @@ class Parser : public AsyncWrap, public StreamListener {
}
}

// TODO(@anonrig): Add V8 Fast API
template <bool should_pause>
static void Pause(const FunctionCallbackInfo<Value>& args) {
Environment* env = Environment::GetCurrent(args);
Expand All @@ -709,7 +711,7 @@ class Parser : public AsyncWrap, public StreamListener {
}
}


// TODO(@anonrig): Add V8 Fast API
static void Consume(const FunctionCallbackInfo<Value>& args) {
Parser* parser;
ASSIGN_OR_RETURN_UNWRAP(&parser, args.This());
Expand All @@ -719,7 +721,7 @@ class Parser : public AsyncWrap, public StreamListener {
stream->PushStreamListener(parser);
}


// TODO(@anonrig): Add V8 Fast API
static void Unconsume(const FunctionCallbackInfo<Value>& args) {
Parser* parser;
ASSIGN_OR_RETURN_UNWRAP(&parser, args.This());
Expand All @@ -745,26 +747,6 @@ class Parser : public AsyncWrap, public StreamListener {
}
}

static void Duration(const FunctionCallbackInfo<Value>& args) {
Parser* parser;
ASSIGN_OR_RETURN_UNWRAP(&parser, args.This());

if (parser->last_message_start_ == 0) {
args.GetReturnValue().Set(0);
return;
}

double duration = (uv_hrtime() - parser->last_message_start_) / 1e6;
args.GetReturnValue().Set(duration);
}

static void HeadersCompleted(const FunctionCallbackInfo<Value>& args) {
Parser* parser;
ASSIGN_OR_RETURN_UNWRAP(&parser, args.This());

args.GetReturnValue().Set(parser->headers_completed_);
}

protected:
static const size_t kAllocBufferSize = 64 * 1024;

Expand Down Expand Up @@ -1311,8 +1293,6 @@ void CreatePerIsolateProperties(IsolateData* isolate_data,
SetProtoMethod(isolate, t, "consume", Parser::Consume);
SetProtoMethod(isolate, t, "unconsume", Parser::Unconsume);
SetProtoMethod(isolate, t, "getCurrentBuffer", Parser::GetCurrentBuffer);
SetProtoMethod(isolate, t, "duration", Parser::Duration);
SetProtoMethod(isolate, t, "headersCompleted", Parser::HeadersCompleted);

SetConstructorFunction(isolate, target, "HTTPParser", t);

Expand Down Expand Up @@ -1382,8 +1362,6 @@ void RegisterExternalReferences(ExternalReferenceRegistry* registry) {
registry->Register(Parser::Consume);
registry->Register(Parser::Unconsume);
registry->Register(Parser::GetCurrentBuffer);
registry->Register(Parser::Duration);
registry->Register(Parser::HeadersCompleted);
registry->Register(ConnectionsList::New);
registry->Register(ConnectionsList::All);
registry->Register(ConnectionsList::Idle);
Expand Down
Loading