Skip to content

tools: ignore V8 tests in CodeQL scans #58081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 2, 2025
Merged

tools: ignore V8 tests in CodeQL scans #58081

merged 1 commit into from
May 2, 2025

Conversation

Trott
Copy link
Member

@Trott Trott commented Apr 30, 2025 •
edited
Loading

CodeQL reports hundreds of errors in V8 tests indicating 'A parse error occurred'. Code quality issues (real or spurious) in V8 tests are not a concern for Node.js. Exclude the tests from CodeQL scans.

@Trott
tools: ignore V8 tests in CodeQL scans
7f6d25d 
CodeQL reports hundreds of errors in V8 tests indicating 'A parse error
occurred'. Code quality issues in V8 tests are not a concern for
Node.js. Exclude the tests from CodeQL scans.
@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Apr 30, 2025
@Trott
Copy link
Member Author

Trott commented Apr 30, 2025

I tested this with a GitHub Actions run on my own fork. The output of the run can be viewed at https://github.com/Trott/io.js/actions/runs/14747812391/job/41398383593.

@Trott Trott added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Apr 30, 2025
mhdawson
mhdawson approved these changes Apr 30, 2025
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bjohansebas
bjohansebas approved these changes May 1, 2025
View reviewed changes
Copy link
Member

@bjohansebas bjohansebas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't we do this for the other dependencies?

@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 2, 2025
@nodejs-github-bot nodejs-github-bot merged commit fca4107 into nodejs:main May 2, 2025
25 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in fca4107

@Trott Trott deleted the v8-tests-exclude branch May 2, 2025 17:46
RafaelGSS pushed a commit that referenced this pull request May 2, 2025
@Trott @RafaelGSS
tools: ignore V8 tests in CodeQL scans
ae08210 
CodeQL reports hundreds of errors in V8 tests indicating 'A parse error
occurred'. Code quality issues in V8 tests are not a concern for
Node.js. Exclude the tests from CodeQL scans.

PR-URL: #58081
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
@RafaelGSS RafaelGSS mentioned this pull request May 2, 2025
Merged
aduh95 pushed a commit that referenced this pull request May 6, 2025
@Trott @aduh95
tools: ignore V8 tests in CodeQL scans
a37f5f8 
CodeQL reports hundreds of errors in V8 tests indicating 'A parse error
occurred'. Code quality issues in V8 tests are not a concern for
Node.js. Exclude the tests from CodeQL scans.

PR-URL: #58081
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
aduh95 pushed a commit that referenced this pull request May 6, 2025
@Trott @aduh95
tools: ignore V8 tests in CodeQL scans
1fd0a3f 
CodeQL reports hundreds of errors in V8 tests indicating 'A parse error
occurred'. Code quality issues in V8 tests are not a concern for
Node.js. Exclude the tests from CodeQL scans.

PR-URL: #58081
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
RafaelGSS pushed a commit that referenced this pull request May 14, 2025
@Trott @RafaelGSS
tools: ignore V8 tests in CodeQL scans
e7514fb 
CodeQL reports hundreds of errors in V8 tests indicating 'A parse error
occurred'. Code quality issues in V8 tests are not a concern for
Node.js. Exclude the tests from CodeQL scans.

PR-URL: #58081
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
aduh95 pushed a commit that referenced this pull request May 16, 2025
@Trott @aduh95
tools: ignore V8 tests in CodeQL scans
9c69299 
CodeQL reports hundreds of errors in V8 tests indicating 'A parse error
occurred'. Code quality issues in V8 tests are not a concern for
Node.js. Exclude the tests from CodeQL scans.

PR-URL: #58081
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
aduh95 pushed a commit that referenced this pull request May 17, 2025
@Trott @aduh95
tools: ignore V8 tests in CodeQL scans
4c8a2e4 
CodeQL reports hundreds of errors in V8 tests indicating 'A parse error
occurred'. Code quality issues in V8 tests are not a concern for
Node.js. Exclude the tests from CodeQL scans.

PR-URL: #58081
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
aduh95 pushed a commit that referenced this pull request May 17, 2025
@Trott @aduh95
tools: ignore V8 tests in CodeQL scans
3eabcb8 
CodeQL reports hundreds of errors in V8 tests indicating 'A parse error
occurred'. Code quality issues in V8 tests are not a concern for
Node.js. Exclude the tests from CodeQL scans.

PR-URL: #58081
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
aduh95 pushed a commit that referenced this pull request May 17, 2025
@Trott @aduh95
tools: ignore V8 tests in CodeQL scans
7d5be81 
CodeQL reports hundreds of errors in V8 tests indicating 'A parse error
occurred'. Code quality issues in V8 tests are not a concern for
Node.js. Exclude the tests from CodeQL scans.

PR-URL: #58081
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
aduh95 pushed a commit that referenced this pull request May 18, 2025
@Trott @aduh95
tools: ignore V8 tests in CodeQL scans
c92b5cd 
CodeQL reports hundreds of errors in V8 tests indicating 'A parse error
occurred'. Code quality issues in V8 tests are not a concern for
Node.js. Exclude the tests from CodeQL scans.

PR-URL: #58081
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
@github-actions github-actions bot mentioned this pull request May 19, 2025
Merged
aduh95 pushed a commit that referenced this pull request May 19, 2025
@Trott @aduh95
tools: ignore V8 tests in CodeQL scans
1b37161 
CodeQL reports hundreds of errors in V8 tests indicating 'A parse error
occurred'. Code quality issues in V8 tests are not a concern for
Node.js. Exclude the tests from CodeQL scans.

PR-URL: #58081
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@anonrig anonrig anonrig approved these changes

@targos targos targos approved these changes

@cjihrig cjihrig cjihrig approved these changes

@mhdawson mhdawson mhdawson approved these changes

@trivikr trivikr trivikr approved these changes

@atlowChemi atlowChemi atlowChemi approved these changes

@bjohansebas bjohansebas bjohansebas approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@Trott @nodejs-github-bot @lpinca @anonrig @targos @cjihrig @mhdawson @trivikr @atlowChemi @bjohansebas