test: add missing newlines to repl .exit writes #58041
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
| @@ -9,7 +9,8 @@ const r = initRepl(); | |||
|
|
|||
| r.input.emit('data', 'function a() { return 42; } (1)\n'); | |||
| r.input.emit('data', 'a\n'); | |||
| r.input.emit('data', '.exit'); | |||
| r.input.emit('data', '.exit\n'); | |||
| r.once('exit', common.mustCall()); | |||
There was a problem hiding this comment.
this new mustCall assertion is unnecessary, I can remove it if people don't like this addition
Note: prior to the \n addition this would cause the test to fail
some tests write `.exit` into a repl server without including a newline character (`\n`), such commands are therefore simply not executed at all, the changes here add the missing newlines and as a side effect remove no longer necessary `end` calls
dario-piotrowicz
force-pushed
the
dario/test-repls-exits
branch
from
b51c424 to
e8e2d7a
Compare
|
Alternatively is preferred the various But I think that keeping them in is the more correct solution 🙂 |
lpinca
approved these changes
Apr 26, 2025
github-actions
bot
removed
the
request-ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58041 +/- ##
==========================================
- Coverage 90.28% 90.27% -0.01%
==========================================
Files 630 630
Lines 186150 186328 +178
Branches 36468 36510 +42
==========================================
+ Hits 168059 168205 +146
- Misses 10975 11009 +34
+ Partials 7116 7114 -2 🚀 New features to boost your workflow:
|
bjohansebas
approved these changes
Apr 27, 2025
jakecastelli
approved these changes
Apr 28, 2025
jakecastelli
added
author ready
nodejs-github-bot
removed
the
commit-queue
|
Landed in 53abd1a |
RafaelGSS
pushed a commit
that referenced
this pull request
May 1, 2025
some tests write `.exit` into a repl server without including a newline character (`\n`), such commands are therefore simply not executed at all, the changes here add the missing newlines and as a side effect remove no longer necessary `end` calls PR-URL: #58041 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
May 2, 2025
some tests write `.exit` into a repl server without including a newline character (`\n`), such commands are therefore simply not executed at all, the changes here add the missing newlines and as a side effect remove no longer necessary `end` calls PR-URL: #58041 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
May 6, 2025
some tests write `.exit` into a repl server without including a newline character (`\n`), such commands are therefore simply not executed at all, the changes here add the missing newlines and as a side effect remove no longer necessary `end` calls PR-URL: #58041 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
May 6, 2025
some tests write `.exit` into a repl server without including a newline character (`\n`), such commands are therefore simply not executed at all, the changes here add the missing newlines and as a side effect remove no longer necessary `end` calls PR-URL: #58041 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
May 14, 2025
some tests write `.exit` into a repl server without including a newline character (`\n`), such commands are therefore simply not executed at all, the changes here add the missing newlines and as a side effect remove no longer necessary `end` calls PR-URL: #58041 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
May 16, 2025
some tests write `.exit` into a repl server without including a newline character (`\n`), such commands are therefore simply not executed at all, the changes here add the missing newlines and as a side effect remove no longer necessary `end` calls PR-URL: #58041 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
May 17, 2025
some tests write `.exit` into a repl server without including a newline character (`\n`), such commands are therefore simply not executed at all, the changes here add the missing newlines and as a side effect remove no longer necessary `end` calls PR-URL: #58041 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
May 17, 2025
some tests write `.exit` into a repl server without including a newline character (`\n`), such commands are therefore simply not executed at all, the changes here add the missing newlines and as a side effect remove no longer necessary `end` calls PR-URL: #58041 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
May 17, 2025
some tests write `.exit` into a repl server without including a newline character (`\n`), such commands are therefore simply not executed at all, the changes here add the missing newlines and as a side effect remove no longer necessary `end` calls PR-URL: #58041 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
May 18, 2025
some tests write `.exit` into a repl server without including a newline character (`\n`), such commands are therefore simply not executed at all, the changes here add the missing newlines and as a side effect remove no longer necessary `end` calls PR-URL: #58041 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
May 19, 2025
some tests write `.exit` into a repl server without including a newline character (`\n`), such commands are therefore simply not executed at all, the changes here add the missing newlines and as a side effect remove no longer necessary `end` calls PR-URL: #58041 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that some repl tests write
".exit"in the repl, without a newline character (\n), as far as I can tell such write operations don't have any effect (removing those lines don't cause any test failures (AFAICT)).I'm adding the missing newline characters so that the exit command is actually executed.
As part of this I'm also removing some
endcalls applied to the repl streams that are no longer necessary.