build: use clang-cl in coverage-windows workflow #57919
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
the
meta
targos
added
dont-land-on-v18.x
dont-land-on-v20.x
And do not lose time trying to regenerate the project and rebuild before running the tests.
targos
force-pushed
the
win-clang-action
branch
from
27d77ce to
106b1a7
Compare
targos
changed the title
lpinca
approved these changes
Apr 17, 2025
anonrig
approved these changes
Apr 18, 2025
targos
added
author ready
nodejs-github-bot
removed
the
commit-queue
|
Landed in 25842c5 |
RafaelGSS
pushed a commit
that referenced
this pull request
May 1, 2025
And do not lose time trying to regenerate the project and rebuild before running the tests. PR-URL: #57919 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
RafaelGSS
pushed a commit
that referenced
this pull request
May 2, 2025
And do not lose time trying to regenerate the project and rebuild before running the tests. PR-URL: #57919 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And do not lose time trying to regenerate the project and rebuild
before running the tests.