Skip to content

deps: delete OpenSSL demos, doc and test folders #57835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 13, 2025

Conversation

targos
Copy link
Member

@targos targos commented Apr 11, 2025

And ignore them for future updates.

And ignore them for future updates.
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. openssl Issues and PRs related to the OpenSSL dependency. labels Apr 11, 2025
@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 11, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 11, 2025
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@targos targos added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Apr 12, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 13, 2025
@nodejs-github-bot nodejs-github-bot merged commit dfaded8 into nodejs:main Apr 13, 2025
73 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in dfaded8

@targos targos deleted the rm-openssl-folders branch April 13, 2025 16:29
RafaelGSS pushed a commit that referenced this pull request May 1, 2025
And ignore them for future updates.

PR-URL: #57835
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@richardlau richardlau added dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v23.x dont-land-on-v24.x PRs that should not land on the v18.x-staging branch and should not be released in v24.x. and removed dont-land-on-v24.x PRs that should not land on the v18.x-staging branch and should not be released in v24.x. labels May 1, 2025
@richardlau
Copy link
Member

This needs to be reverted (#58099) to fix the OpenSSL update scripts which rely on being able to run parts of the OpenSSL configuration/build that errors if at least docs is missing. I've stuck dont-land labels to stop this being backported to releases (I think it may already be on the v24.x-staging branch/v24.0.0-proposal cc @RafaelGSS ).

RafaelGSS pushed a commit that referenced this pull request May 2, 2025
And ignore them for future updates.

PR-URL: #57835
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. dependencies Pull requests that update a dependency file. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. needs-ci PRs that need a full CI run. openssl Issues and PRs related to the OpenSSL dependency.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants