-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
deps: delete OpenSSL demos, doc and test folders #57835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And ignore them for future updates.
Review requested:
|
marco-ippolito
approved these changes
Apr 11, 2025
lpinca
approved these changes
Apr 11, 2025
jasnell
approved these changes
Apr 12, 2025
Landed in dfaded8 |
RafaelGSS
pushed a commit
that referenced
this pull request
May 1, 2025
And ignore them for future updates. PR-URL: #57835 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This needs to be reverted (#58099) to fix the OpenSSL update scripts which rely on being able to run parts of the OpenSSL configuration/build that errors if at least docs is missing. I've stuck dont-land labels to stop this being backported to releases (I think it may already be on the v24.x-staging branch/v24.0.0-proposal cc @RafaelGSS ). |
RafaelGSS
pushed a commit
that referenced
this pull request
May 2, 2025
And ignore them for future updates. PR-URL: #57835 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
dependencies
Pull requests that update a dependency file.
dont-land-on-v20.x
PRs that should not land on the v20.x-staging branch and should not be released in v20.x.
dont-land-on-v22.x
PRs that should not land on the v22.x-staging branch and should not be released in v22.x.
needs-ci
PRs that need a full CI run.
openssl
Issues and PRs related to the OpenSSL dependency.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And ignore them for future updates.