doc: clarify Corepack removal in v25+ #57813
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trivikr
added
dont-land-on-v18.x
dont-land-on-v20.x
trivikr
commented
Apr 10, 2025
MikeMcC399
reviewed
Apr 10, 2025
ljharb
approved these changes
Apr 10, 2025
|
The commit message do not match our guidelines, the first word after the subsystem should be an imperative verb. |
Co-authored-by: Mike McCready <66998419+MikeMcC399@users.noreply.github.com>
trivikr
force-pushed
the
trivikr/doc-corepack
branch
from
f163dc7 to
3b95127
Compare
trivikr
changed the title
|
@aduh95 I've updated the first commit to use imperative verb after subsystem: |
lpinca
approved these changes
Apr 10, 2025
trivikr
commented
Apr 10, 2025
|
Closing this PR, as the existing documentation can be edited better with highlight and call to action just like it's done for other modules for all Node.js versions. That PR is posted in #57825 |
|
I'll post a new PR specific to v25.x after #57825 is merged. |
|
We're instead trying to enable redirect from corepack latest documentation in nodejs/nodejs.org#7643 (review) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #57663
This preserves the existing documentation page for corepack which has backlinks from all over the internet.
It can be removed close to April 2028, after corepack is completely removed from all Node.js versions.
Refs: