src: improve error handling in callback.cc #57758
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoiding use of v8 `Checked()` APIs where appropriate. Few other style cleanups
nodejs-github-bot
added
c++
aduh95
approved these changes
Apr 5, 2025
aduh95
added
author ready
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
anonrig
approved these changes
Apr 6, 2025
jasnell
added a commit
that referenced
this pull request
Apr 7, 2025
Avoiding use of v8 `Checked()` APIs where appropriate. Few other style cleanups PR-URL: #57758 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
|
Landed in a5877d0 |
JonasBa
pushed a commit
to JonasBa/node
that referenced
this pull request
Apr 11, 2025
Avoiding use of v8 `Checked()` APIs where appropriate. Few other style cleanups PR-URL: nodejs#57758 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
RafaelGSS
pushed a commit
that referenced
this pull request
May 1, 2025
Avoiding use of v8 `Checked()` APIs where appropriate. Few other style cleanups PR-URL: #57758 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
RafaelGSS
pushed a commit
that referenced
this pull request
May 2, 2025
Avoiding use of v8 `Checked()` APIs where appropriate. Few other style cleanups PR-URL: #57758 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
aduh95
pushed a commit
that referenced
this pull request
May 6, 2025
Avoiding use of v8 `Checked()` APIs where appropriate. Few other style cleanups PR-URL: #57758 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
RafaelGSS
pushed a commit
that referenced
this pull request
May 14, 2025
Avoiding use of v8 `Checked()` APIs where appropriate. Few other style cleanups PR-URL: #57758 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
aduh95
pushed a commit
that referenced
this pull request
May 16, 2025
Avoiding use of v8 `Checked()` APIs where appropriate. Few other style cleanups PR-URL: #57758 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
aduh95
pushed a commit
that referenced
this pull request
May 17, 2025
Avoiding use of v8 `Checked()` APIs where appropriate. Few other style cleanups PR-URL: #57758 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
aduh95
pushed a commit
that referenced
this pull request
May 17, 2025
Avoiding use of v8 `Checked()` APIs where appropriate. Few other style cleanups PR-URL: #57758 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
aduh95
pushed a commit
that referenced
this pull request
May 17, 2025
Avoiding use of v8 `Checked()` APIs where appropriate. Few other style cleanups PR-URL: #57758 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
aduh95
pushed a commit
that referenced
this pull request
May 19, 2025
Avoiding use of v8 `Checked()` APIs where appropriate. Few other style cleanups PR-URL: #57758 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoiding use of v8
Checked()APIs where appropriate. Few other style cleanups