sqlite: add setReturnArrays method to StatementSync #57542

gurgunday · 2025-03-19T00:48:06Z

Add a new StatementSync method setReturnArrays() that allows query results to be returned as arrays instead of objects. This is more efficient when column names are meaningless, auto-generated, or when working with hundreds of columns.

Fixes #57534

It's my first significant C++ PR, hopefully first of many :)

nodejs-github-bot · 2025-03-19T00:48:11Z

Review requested:

@nodejs/sqlite

src/node_sqlite.cc

anonrig · 2025-03-19T01:30:48Z

Cc @nodejs/cpp-reviewers

codecov · 2025-03-19T02:14:41Z

Codecov Report

Attention: Patch coverage is 85.85859% with 14 lines in your changes missing coverage. Please review.

Project coverage is 90.25%. Comparing base (32e5e81) to head (5420ed5).
Report is 11 commits behind head on main.

Files with missing lines	Patch %	Lines
src/node_sqlite.cc	85.85%	0 Missing and 14 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #57542      +/-   ##
==========================================
+ Coverage   90.24%   90.25%   +0.01%     
==========================================
  Files         630      630              
  Lines      184990   185042      +52     
  Branches    36214    36232      +18     
==========================================
+ Hits       166941   167008      +67     
+ Misses      11002    10996       -6     
+ Partials     7047     7038       -9

Files with missing lines	Coverage Δ
src/node_sqlite.h	`63.63% <ø> (ø)`
src/node_sqlite.cc	`80.52% <85.85%> (+<0.01%)`	⬆️

... and 22 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

test/parallel/test-sqlite-statement-sync.js

src/node_sqlite.cc

cjihrig · 2025-03-19T13:25:41Z

Oh, and this needs documentation.

src/node_sqlite.cc

gurgunday · 2025-03-19T22:38:50Z

I'll add docs once the code is approved

cjihrig · 2025-03-20T19:58:51Z

I've opened #57569 to refactor the iterator implementation. I think we should land that PR before this one so that we can avoid exposing iterator internal state to JS.

cjihrig · 2025-04-03T14:24:46Z

This needs a rebase, but we can finally move this forward.

gurgunday · 2025-04-03T15:16:55Z

Yep, will rebase asap

nodejs-github-bot · 2025-04-04T21:26:54Z

Landed in 054371d

PR-URL: nodejs#57542 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

PR-URL: #57542 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

tniessen · 2025-06-18T16:43:30Z

@gurgunday @cjihrig Was there any discussion of how the internal state of a StatementSync (i.e., whether it will return an array or an object) should be reflected in the TypeScript declarations?

PR-URL: #59074 Refs: #57542 Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

PR-URL: nodejs#59074 Refs: nodejs#57542 Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

PR-URL: #59074 Refs: #57542 Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

PR-URL: #59074 Backport-PR-URL: #59099 Refs: #57542 Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. sqlite Issues and PRs related to the SQLite subsystem. labels Mar 19, 2025

gurgunday changed the title ~~sqlite: add setReturnArrays method to StatementSync for toggling arra…~~ sqlite: add setReturnArrays method to StatementSync for toggling array row support Mar 19, 2025

gurgunday force-pushed the sqlite-array branch from d2ea711 to d90c87f Compare March 19, 2025 00:49

gurgunday changed the title ~~sqlite: add setReturnArrays method to StatementSync for toggling array row support~~ sqlite: add setReturnArrays method to StatementSync Mar 19, 2025

geeksilva97 reviewed Mar 19, 2025

View reviewed changes

src/node_sqlite.cc Outdated Show resolved Hide resolved

anonrig requested review from anonrig, cjihrig and jasnell March 19, 2025 01:30

cjihrig reviewed Mar 19, 2025

View reviewed changes

anonrig reviewed Mar 19, 2025

View reviewed changes

src/node_sqlite.cc Outdated Show resolved Hide resolved

src/node_sqlite.cc Outdated Show resolved Hide resolved

src/node_sqlite.cc Outdated Show resolved Hide resolved

gurgunday added 10 commits April 4, 2025 11:33

sqlite: add setReturnArrays method to StatementSync

0111ab7

fix linting

e4f5ea3

apply feedback

6e5357d

format cpp

39cb87a

format cpp

acca8b1

apply feedback

c733e91

use localvector and then create array

de48b93

apply feedback

5824701

format cpp

d053ea5

rebase

4d042f0

cjihrig added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Apr 4, 2025

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 4, 2025

nodejs-github-bot merged commit 054371d into nodejs:main Apr 4, 2025
67 checks passed

gurgunday deleted the sqlite-array branch April 4, 2025 23:20

JonasBa pushed a commit to JonasBa/node that referenced this pull request Apr 11, 2025

sqlite: add setReturnArrays method to StatementSync

255ce35

PR-URL: nodejs#57542 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

RafaelGSS pushed a commit that referenced this pull request May 1, 2025

sqlite: add setReturnArrays method to StatementSync

23b2bc9

PR-URL: #57542 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

RafaelGSS mentioned this pull request May 1, 2025

2025-05-06, Version 24.0.0 (Current) #57609

Merged

RafaelGSS pushed a commit that referenced this pull request May 2, 2025

sqlite: add setReturnArrays method to StatementSync

2b2a0bf

PR-URL: #57542 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

aduh95 pushed a commit that referenced this pull request May 6, 2025

sqlite: add setReturnArrays method to StatementSync

0b50262

PR-URL: #57542 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

aduh95 pushed a commit that referenced this pull request May 6, 2025

sqlite: add setReturnArrays method to StatementSync

4a8b246

PR-URL: #57542 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

RafaelGSS pushed a commit that referenced this pull request May 14, 2025

sqlite: add setReturnArrays method to StatementSync

ac6f7d1

PR-URL: #57542 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

aduh95 pushed a commit that referenced this pull request May 16, 2025

sqlite: add setReturnArrays method to StatementSync

688a954

PR-URL: #57542 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

aduh95 pushed a commit that referenced this pull request May 17, 2025

sqlite: add setReturnArrays method to StatementSync

9a67be8

PR-URL: #57542 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

aduh95 pushed a commit that referenced this pull request May 17, 2025

sqlite: add setReturnArrays method to StatementSync

e8ec01d

PR-URL: #57542 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

aduh95 pushed a commit that referenced this pull request May 17, 2025

sqlite: add setReturnArrays method to StatementSync

f996ab0

PR-URL: #57542 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

aduh95 pushed a commit that referenced this pull request May 18, 2025

sqlite: add setReturnArrays method to StatementSync

ad464f3

PR-URL: #57542 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

github-actions bot mentioned this pull request May 19, 2025

2025-05-21, Version 22.16.0 'Jod' (LTS) #58388

Merged

aduh95 pushed a commit that referenced this pull request May 19, 2025

sqlite: add setReturnArrays method to StatementSync

5e0503a

PR-URL: #57542 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

ghost mentioned this pull request Jun 8, 2025

### Notable Changes autofix-ci/action#28

Closed

aduh95 mentioned this pull request Jul 17, 2025

sqlite,doc: add setReturnArrays missing docs #59074

Merged

aduh95 pushed a commit that referenced this pull request Jul 17, 2025

doc: add missing section for setReturnArrays in sqlite.md

ee1ec50

PR-URL: #59074 Refs: #57542 Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

aduh95 pushed a commit to geeksilva97/node that referenced this pull request Jul 17, 2025

doc: add missing section for setReturnArrays in sqlite.md

8eaa19a

PR-URL: nodejs#59074 Refs: nodejs#57542 Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

aduh95 pushed a commit that referenced this pull request Jul 17, 2025

doc: add missing section for setReturnArrays in sqlite.md

34c4900

PR-URL: #59074 Refs: #57542 Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

aduh95 pushed a commit that referenced this pull request Aug 21, 2025

doc: add missing section for setReturnArrays in sqlite.md

997171d

PR-URL: #59074 Backport-PR-URL: #59099 Refs: #57542 Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

aduh95 pushed a commit that referenced this pull request Aug 21, 2025

doc: add missing section for setReturnArrays in sqlite.md

f7924a1

PR-URL: #59074 Backport-PR-URL: #59099 Refs: #57542 Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

aduh95 pushed a commit that referenced this pull request Aug 25, 2025

doc: add missing section for setReturnArrays in sqlite.md

343dbc8

PR-URL: #59074 Backport-PR-URL: #59099 Refs: #57542 Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

aduh95 pushed a commit that referenced this pull request Aug 26, 2025

doc: add missing section for setReturnArrays in sqlite.md

e22aeaa

PR-URL: #59074 Backport-PR-URL: #59099 Refs: #57542 Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Uh oh!

sqlite: add setReturnArrays method to StatementSync #57542

sqlite: add setReturnArrays method to StatementSync #57542

Uh oh!

Conversation

gurgunday commented Mar 19, 2025

Uh oh!

nodejs-github-bot commented Mar 19, 2025

Uh oh!

Uh oh!

anonrig commented Mar 19, 2025

Uh oh!

codecov bot commented Mar 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cjihrig commented Mar 19, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gurgunday commented Mar 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cjihrig commented Mar 20, 2025

Uh oh!

cjihrig commented Apr 3, 2025

Uh oh!

gurgunday commented Apr 3, 2025

Uh oh!

Uh oh!

nodejs-github-bot commented Apr 4, 2025

Uh oh!

tniessen commented Jun 18, 2025

Uh oh!

Uh oh!

codecov bot commented Mar 19, 2025 •

edited

Loading

gurgunday commented Mar 19, 2025 •

edited

Loading