Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: remove the use of curl in the test suite #5750

Closed
wants to merge 1 commit into from
Closed

test: remove the use of curl in the test suite #5750

wants to merge 1 commit into from

Commits on Mar 16, 2016

  1. test: remove the use of curl in the test suite 

    There were 2 tests using curl:

`test-http-304.js` is removed because it was initially included to test
that the 304 response does not contain a body, and this is already
covered by `test-http-chunked-304.js`.

`test-http-curl-chunk-problem` has been renamed and refactored so
instead of using curl, it uses 2 child node processes: one for sending
the HTTP request and the other to calculate the sha1sum. Originally,
this test was introduced to fix a bug in `nodejs@0.2.x`, and it was not
fixed until `nodejs@0.2.5`. A modified version of this test has been run
with `nodejs@0.2.0` and reproduces the problem. This same test has been
run with `nodejs@0.2.6` and runs correctly.
    @santigimeno
    santigimeno committed Mar 16, 2016
    Configuration menu
    Copy the full SHA
    821f377 View commit details
    Browse the repository at this point in the history