-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
deps: update ada to 3.1.1 #57190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: update ada to 3.1.1 #57190
Conversation
Review requested:
|
@nodejs/performance can someone run url benchmarks? |
@lemire any idea why we didn't catch this on CI? |
This comment was marked as outdated.
This comment was marked as outdated.
|
Should be fixed by #57197 (was a race condition between two separate PR's landing on |
@richardlau any idea why github 24.04 succeeds but arm doesn't? somehow -Wsign-compare is enabled on github ci for both macos and ubuntu 24.04
|
@anonrig Some of the CI runs with |
hmm but that is set on both the arm and non-arm Ubuntu 24.04 GitHub workflows. I can only assume either:
|
This is an automated update of ada to 3.1.1.