-
Notifications
You must be signed in to change notification settings - Fork 29.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
repl: Default useGlobal
to false in CLI REPL.
#5703
Commits on Jun 29, 2016
-
repl: Default
useGlobal
to false in CLI REPL.This addresses #5659. The documentation for REPL states that the default value of `useGlobal` is `false`. It makes no distinction between a REPL that is created programmatically, and the one a user is dropped into on the command line by executing `node` with no arguments. This change ensures that the CLI REPL uses a default value of `false`.
Configuration menu - View commit details
-
Copy full SHA for affd22c - Browse repository at this point
Copy the full SHA affd22cView commit details -
repl: Incorporate
useGlobal
test feedback from @cjihrigTest three times, once for each of `true`, `false` and `undefined` for the `useGlobal` parameter. Inline the test itself, and lowercase the `repl` variable. Add `common.mustCall()` for all test callback functions.
Configuration menu - View commit details
-
Copy full SHA for d275ced - Browse repository at this point
Copy the full SHA d275cedView commit details -
repl: Add tests for repl eval of
let process;
These changes are meant to address concerns aired in #6802. A test case has been added which tests the behavior of `let process;` when `useGlobal` is `false` or `undefined`. As mentioned in the test comments, setting `useGlobal` to `true` generates the the expected exception, and the `catch` block executes in the test code as expected. But the test framework detects this exception being thrown and fails the build. /usr/bin/python tools/test.py --mode=release -J \ addon doctool known_issues message parallel sequential === release test-repl-use-global === Path: parallel/test-repl-use-global domain.js:99 process._emittingTopLevelDomainError = false; ^ TypeError: Cannot set property '_emittingTopLevelDomainError' of undefined at Domain.errorHandler [as _errorHandler] (domain.js:99:46) at process._fatalException (node.js:269:33) Command: out/Release/node --expose-internals /Users/lanceball/src/node/test/parallel/test-repl-use-global.js [00:52|% 100|+ 1113|- 1]: Done make: *** [test] Error 1
Configuration menu - View commit details
-
Copy full SHA for bf02ed1 - Browse repository at this point
Copy the full SHA bf02ed1View commit details -
repl: Do not test useGlobal=true && let process;
No need to test failure cases, as per @addaleax.
Configuration menu - View commit details
-
Copy full SHA for 0f69e6c - Browse repository at this point
Copy the full SHA 0f69e6cView commit details -
repl: Code style nits and repl output tested.
Addressing comments from @addaleax.
Configuration menu - View commit details
-
Copy full SHA for 02fffc3 - Browse repository at this point
Copy the full SHA 02fffc3View commit details
Commits on Jun 30, 2016
-
repl: change order of default opts in createRepl
Done to make the diff cleaner, per @cjihrig.
Configuration menu - View commit details
-
Copy full SHA for 2694945 - Browse repository at this point
Copy the full SHA 2694945View commit details -
Configuration menu - View commit details
-
Copy full SHA for 997eb87 - Browse repository at this point
Copy the full SHA 997eb87View commit details