test: skip test-sqlite-extensions when it is missing#56455
Closed
aduh95 wants to merge 1 commit intonodejs:mainfrom
Closed
test: skip test-sqlite-extensions when it is missing#56455aduh95 wants to merge 1 commit intonodejs:mainfrom
test-sqlite-extensions when it is missing#56455aduh95 wants to merge 1 commit intonodejs:mainfrom
Conversation
|
I can confirm that this PR fixes the problem for me. When I follow the steps to reproduce in #56453 with this PR’s branch, the test prints this… (node:115653) ExperimentalWarning: SQLite is an experimental feature and might change at any time (Use `node --trace-warnings ...` to show where the warning was created) 1..0 # Skipped: Missing libsqlite_extension binary …and exits with exit status |
Contributor
|
I think the change here will become obsolete once #56446 lands. |
himself65
approved these changes
Jan 3, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #56455 +/- ##
==========================================
- Coverage 88.54% 88.53% -0.01%
==========================================
Files 657 657
Lines 190765 190765
Branches 36611 36613 +2
==========================================
- Hits 168908 168894 -14
- Misses 15036 15044 +8
- Partials 6821 6827 +6 |
Contributor
Author
|
@Jayman2000 can you try with latest |
I’m not able to reproduce this issue with the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
49acdc8 disabled the test when building with
--shared-sqlite, but there are more cases where the extension is not built, and IMO we should not report it as failure and instead skip the test.Fixes: #56453