test: openssl 3.4 compatibility

[adrien-n]

This PR fixes two issues in the testsuite caused by changes in openssl 3.4:

• using SHAKE128 and SHAKE256 requires explicitely setting an output length,
• the error code for one of the failure mode in TLS 1.3 was off-spec.

In addition to #56160 , this should fix
the build of nodejs with openssl 3.4 for Ubuntu 25.04 (Plucky).

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.19%. Comparing base (529b56e) to head (81bdf85).
Report is 26 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #56294      +/-   ##
==========================================
+ Coverage   89.16%   89.19%   +0.02%     
==========================================
  Files         662      662              
  Lines      191746   191797      +51     
  Branches    36902    36922      +20     
==========================================
+ Hits       170970   171065      +95     
+ Misses      13632    13567      -65     
- Partials     7144     7165      +21     

see 49 files with indirect coverage changes

[adrien-n]

Sorry, I wasn't around for a couple weeks.

Thanks for the review and suggestion!
I've updated the branch with the code you proposed, only slightly reformatted to be more amenable to future additional .filter() steps (though, hopefully, there won't be any other needed).

The second patch in the series basically landed separately through #56420 (not from me but the code is probably exactly the same) so I've dropped it from here.

[mhdawson]

LGTM

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/64484/

[adrien-n]

I fixed the two cosmetic issues raised in the GH CI. I'm didn't look at the nodejs.org one due to the permissions it was asking from my GH account and the expectation I wouldn't be able to log in anyway. Let me know if was wrong on these and I should look at it.

[aduh95]

Isn't it already covered by

node/test/parallel/test-crypto-oneshot-hash.js

Lines 35 to 36 in 93c15bf

	if (method.startsWith('shake') && common.hasOpenSSL(3, 4))
	continue;

?

[adrien-n]

On Mon, Jan 13, 2025, Antoine du Hamel wrote: Isn't it already covered by https://github.com/nodejs/node/blob/93c15bfbc79c42244b11f99ca931b5745e508612/test/parallel/test-crypto-oneshot-hash.js#L35-L36?

It looks indeed possible that this covers it. Since the PR just got merged a couple hours, I hadn't seen it and haven't checked it.