Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: dns.resolveCname description typo #5622

Closed
wants to merge 1 commit into from
Closed

Conversation

axvm
Copy link
Contributor

@axvm axvm commented Mar 9, 2016

No description provided.

@mscdex mscdex added doc Issues and PRs related to the documentations. dns Issues and PRs related to the dns subsystem. labels Mar 9, 2016
@mscdex
Copy link
Contributor

mscdex commented Mar 9, 2016

dsn should be dns in the commit message. Otherwise LGTM

@axvm
Copy link
Contributor Author

axvm commented Mar 9, 2016

@mscdex done. Sorry for typo.

@mscdex mscdex changed the title doc: dsn.resolveCname description typo doc: dns.resolveCname description typo Mar 9, 2016
@evanlucas
Copy link
Contributor

LGTM

1 similar comment
@cjihrig
Copy link
Contributor

cjihrig commented Mar 9, 2016

LGTM

@silverwind
Copy link
Contributor

LGTM, landed in a498492.

@silverwind silverwind closed this Mar 10, 2016
silverwind pushed a commit that referenced this pull request Mar 10, 2016
PR-URL: #5622
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
evanlucas pushed a commit that referenced this pull request Mar 14, 2016
PR-URL: #5622
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
@evanlucas evanlucas mentioned this pull request Mar 14, 2016
rvagg pushed a commit that referenced this pull request Mar 16, 2016
PR-URL: #5622
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins pushed a commit that referenced this pull request Mar 17, 2016
PR-URL: #5622
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins pushed a commit that referenced this pull request Mar 21, 2016
PR-URL: #5622
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins pushed a commit that referenced this pull request Mar 21, 2016
PR-URL: #5622
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dns Issues and PRs related to the dns subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants