[do not land] update ada to v3.0-pre

[anonrig]

DO NOT LAND.

Before releasing a new version (soon), let's see if we broke anything with the C++20 upgrade.

cc @lemire @nodejs/url

Benchmark CI: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1655/

[nodejs-github-bot]

Review requested:

• @nodejs/security-wg
• @nodejs/url

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/63991/

[anonrig]

@nodejs/build the current state of macOS (it is too outdated and doesn't have all C++20 features) is going to block having this upgrade, which is OK, but after landing this PR, I'm planning on opening a PR for URLPattern. Would someone share a status update? All that work for URLPattern would be for waste if we can't update our infra.

18:43:13 ../deps/ada/ada.h:977:12: error: no member named 'bit_cast' in namespace 'std'
18:43:13       std::bit_cast<uint16_t>(static_cast<uint16_t>(0x7830));
18:43:13       ~~~~~^
18:43:13 ../deps/ada/ada.h:977:21: error: unexpected type name 'uint16_t': expected expression
18:43:13       std::bit_cast<uint16_t>(static_cast<uint16_t>(0x7830));
18:43:13                     ^
18:43:13 ../deps/ada/ada.h:973:16: error: no return statement in constexpr function
18:43:13 constexpr bool has_hex_prefix_unsafe(std::string_view input) {
18:43:13                ^
18:43:13 ../deps/ada/ada.h:989:16: error: no return statement in constexpr function
18:43:13 constexpr bool has_hex_prefix(std::string_view input) {
18:43:13                ^
18:43:13   cc -o /Users/iojs/build/workspace/node-test-commit-osx-

[anonrig]

cc @nodejs/platform-smartos smartOS has missing implementation for std::bit_cast. This is blocking updating Ada in the future.

18:45:57 ../deps/ada/ada.h:977:12: error: 'bit_cast' is not a member of 'std'; did you mean 'bad_cast'?
18:45:57   977 |       std::bit_cast<uint16_t>(static_cast<uint16_t>(0x7830));
18:45:57       |            ^~~~~~~~
18:45:57       |            bad_cast
18:45:57 ../deps/ada/ada.h:977:29: error: expected primary-expression before '>' token
18:45:57   977 |       std::bit_cast<uint16_t>(static_cast<uint16_t>(0x7830));
18:45:57       |                             ^
18:45:57 In file included from ../deps/ada/ada.cpp:3:

[anonrig]

Note: All other failures are from unexpected passes from WPT

[bahamat]

cc @nodejs/platform-smartos smartOS has missing implementation for std::bit_cast. This is blocking updating Ada in the future.

As I understand it, gcc11 is the requirement for this. I've proposed we move to building using the 22.4.0 image which has gcc12.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/64034/

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.54%. Comparing base (e698bd0) to head (e9794ec).
Report is 234 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #56218      +/-   ##
==========================================
+ Coverage   88.53%   88.54%   +0.01%     
==========================================
  Files         657      657              
  Lines      190203   190203              
  Branches    36528    36524       -4     
==========================================
+ Hits       168402   168423      +21     
+ Misses      14987    14983       -4     
+ Partials     6814     6797      -17     

see 23 files with indirect coverage changes

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/64057/