deps: fix v8 armv6 run-time detection #559
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM if it works |
The elf_platform suffix in /proc/cpuinfo moved to the model name field in Linux 3.8. Out-of-tree patch pending https://codereview.chromium.org/867713003/ Fixes: nodejs#283 PR-URL: nodejs#559 Reviewed-By: Fedor Indutny <fedor@indutny.com>
VFPv3 is ARMv7-only, enabling it for ARMv6 is therefore always wrong. Mea culpa, I do believe I'm the original author of that change. Fixes: nodejs#283 PR-URL: nodejs#559 Reviewed-By: Fedor Indutny <fedor@indutny.com>
Remove the configure check, the flag was dropped in V8 3.28. PR-URL: nodejs#559 Reviewed-By: Fedor Indutny <fedor@indutny.com>
bnoordhuis
force-pushed
the
fix-issue-283
branch
from
2e6670f to
c6cd460
Compare
misterdjules
pushed a commit
to misterdjules/node
that referenced
this pull request
Mar 30, 2015
Port 297cadb from io.js. Original commit message: The elf_platform suffix in /proc/cpuinfo moved to the model name field in Linux 3.8. Out-of-tree patch pending https://codereview.chromium.org/867713003/ Fixes: nodejs/node#283 PR-URL: nodejs/node#559 Reviewed-By: Fedor Indutny <fedor@indutny.com>
misterdjules
pushed a commit
to misterdjules/node
that referenced
this pull request
Mar 30, 2015
Port 7d9d756 from io.js. Original commit message: VFPv3 is ARMv7-only, enabling it for ARMv6 is therefore always wrong. Mea culpa, I do believe I'm the original author of that change. Fixes: nodejs/node#283 PR-URL: nodejs/node#559 Reviewed-By: Fedor Indutny <fedor@indutny.com>
misterdjules
pushed a commit
to misterdjules/node
that referenced
this pull request
Mar 30, 2015
Port c6cd460 from io.js. Original commit message: Remove the configure check, the flag was dropped in V8 3.28. PR-URL: nodejs/node#559 Reviewed-By: Fedor Indutny <fedor@indutny.com>
This was referenced Sep 13, 2021
This was referenced Jul 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The elf_platform suffix in /proc/cpuinfo moved to the model name field
in Linux 3.8.
Out-of-tree patch pending https://codereview.chromium.org/867713003/
Fixes: iojs#283
R=@indutny @silverwind @wilson0x4d
https://jenkins-iojs.nodesource.com/view/iojs/job/iojs+any-pr+multi/99/