Enabling ClangCL compilation testing #55784
Draft
+7
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a draft to discuss the changes needed to run test jobs in the CI for the ClangCL-produced binaries. It is not expected to land like this, just to discuss before opening production-ready PRs:
config.variables.clang
is set to 1, which makes node-gyp generate project files for ClangCL. While we'd like to enable this, that is currently not the priority so for now enforcing MSVC would be the way to go the way I see it. The changes increate-config-gypi.js
would be done as a PR in node-gyp and then floated in Node.js until the next node-gyp update.V8_PRESERVE_MOST
on Windows. We already have something similar forV8_NODISCARD
as a floating patch, so it should not be a problem as I see it. If left, this results in functions that use it having__swift_2
calling conventions rather than the expected__cdecl
. This was noticed incppgc-object
native suites test. This change, if agreed upon, would be come one of our V8 floating patches we use on each V8 update.Tagging relative teams/people: @nodejs/platform-windows @nodejs/node-gyp @targos