Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add path aliases typescript doc #55766

Merged
merged 3 commits into from
Nov 8, 2024

Conversation

Ceres6
Copy link
Contributor

@Ceres6 Ceres6 commented Nov 7, 2024

Adding path aliases not supported documentation and alternative to TypeScript documentation

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/typescript

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Nov 7, 2024
Copy link
Contributor

@JakobJingleheimer JakobJingleheimer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think more specificity for where/what path comes from would be better.

doc/api/typescript.md Outdated Show resolved Hide resolved
doc/api/typescript.md Outdated Show resolved Hide resolved
doc/api/typescript.md Outdated Show resolved Hide resolved
Co-authored-by: Jake Bailey <5341706+jakebailey@users.noreply.github.com>
@JakobJingleheimer JakobJingleheimer added fast-track PRs that do not need to wait for 48 hours to land. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Nov 8, 2024
Copy link
Contributor

github-actions bot commented Nov 8, 2024

Fast-track has been requested by @JakobJingleheimer. Please 👍 to approve.

@JakobJingleheimer JakobJingleheimer added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 8, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 8, 2024
@nodejs-github-bot nodejs-github-bot merged commit 765f16c into nodejs:main Nov 8, 2024
25 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 765f16c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants