Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add double space in README.md #55765

Closed
wants to merge 1 commit into from

Conversation

Manishkumarchintawar
Copy link

No description provided.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/actions
  • @nodejs/tsc

@nodejs-github-bot nodejs-github-bot added meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory. labels Nov 7, 2024
@aduh95 aduh95 reopened this Nov 7, 2024
@aduh95 aduh95 changed the base branch from feature/wasm-streaming-handler to main November 7, 2024 14:15
@aduh95
Copy link
Contributor

aduh95 commented Nov 7, 2024

Thanks for the PR! Next time please make sure to read our contributing guidelines, e.g. our commit message guidelines:

A good commit message should describe what changed and why.
1. The first line should:
* contain a short description of the change (preferably 50 characters or
less, and no more than 72 characters)
* be entirely in lowercase with the exception of proper nouns, acronyms, and
the words that refer to code, like function/variable names
* be prefixed with the name of the changed [subsystem](#appendix-subsystems)
and start with an imperative verb. Check the output of `git log --oneline
files/you/changed` to find out what subsystems your changes touch.
Examples:
* `net: add localAddress and localPort to Socket`
* `src: fix typos in async_wrap.h`
2. Keep the second line blank.
3. Wrap all other lines at 72 columns (except for long URLs).

@aduh95 aduh95 changed the title newly arrived doc: remove double space in README.md Nov 7, 2024
aduh95
aduh95 previously approved these changes Nov 7, 2024
@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 7, 2024
@marco-ippolito
Copy link
Member

it looks to me this adds a double space, not remove it

@aduh95 aduh95 dismissed their stale review November 7, 2024 14:23

Misread the diff, I don't think it's a good addition

@aduh95 aduh95 changed the title doc: remove double space in README.md doc: add double space in README.md Nov 7, 2024
@marco-ippolito marco-ippolito removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 7, 2024
@marco-ippolito
Copy link
Member

I think we can close this

@aduh95
Copy link
Contributor

aduh95 commented Nov 7, 2024

@Manishkumarchintawar you're welcome to send PRs that improves stuff or remove inconsistencies, but sending a PR that adds inconsistency is not OK, it's only wasting maintainers' time.

@aduh95 aduh95 closed this Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants