test: improve test coverage for child process message sending #55710
+3
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
juanarbol
added
child_process
juanarbol
force-pushed
the
juan/cp-exception
branch
from
8386943
to
d99344a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #55710 +/- ##
=======================================
Coverage 88.39% 88.40%
=======================================
Files 654 654
Lines 187560 187560
Branches 36087 36088 +1
=======================================
+ Hits 165800 165818 +18
+ Misses 14996 14987 -9
+ Partials 6764 6755 -9 |
Signed-off-by: Juan José Arboleda <soyjuanarbol@gmail.com>
juanarbol
force-pushed
the
juan/cp-exception
branch
from
d99344a
to
1b11e19
Compare
github-actions
bot
removed
the
request-ci
github-actions
bot
removed
the
request-ci
LiviaMedeiros
approved these changes
Nov 6, 2024
LiviaMedeiros
added
the
author ready
juanarbol
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/55710 ✔ Done loading data for nodejs/node/pull/55710 ----------------------------------- PR info ------------------------------------ Title test: improve test coverage for child process message sending (#55710) Author Juan José <soyjuanarbol@gmail.com> (@juanarbol) Branch juanarbol:juan/cp-exception -> nodejs:main Labels child_process, test, author ready, needs-ci Commits 1 - test: improve test coverage for child process message sending Committers 1 - Juan José Arboleda <soyjuanarbol@gmail.com> PR-URL: https://github.com/nodejs/node/pull/55710 Reviewed-By: LiviaMedeiros <livia@cirno.name> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/55710 Reviewed-By: LiviaMedeiros <livia@cirno.name> -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 04 Nov 2024 03:35:01 GMT ✔ Approvals: 1 ✔ - LiviaMedeiros (@LiviaMedeiros): https://github.com/nodejs/node/pull/55710#pullrequestreview-2417835559 ✘ This PR needs to wait 76 more hours to land (or 0 hours if there is one more approval) ✔ Last GitHub CI successful ℹ Last Full PR CI on 2024-11-04T07:45:22Z: https://ci.nodejs.org/job/node-test-pull-request/63417/ - Querying data for job/node-test-pull-request/63417/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/11732967079 |
aduh95
approved these changes
Nov 8, 2024
aduh95
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 5d85b05 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch will include this uncovered fraction of code: https://app.codecov.io/gh/nodejs/node/blob/main/lib%2Finternal%2Fchild_process.js#L807