Upgrade to V8 4.9 in master #5539
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pick up the current branch head for V8 4.9 v8/v8@1ecba0f PR-URL: nodejs#4722 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
PR-URL: nodejs#4722 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
PR-URL: nodejs#4722 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
- An error message changed for undefined references - `let` is now allowed in sloppy mode - ES2015 proxies are shipped and the `Proxy` global is now a function PR-URL: nodejs#4722 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Proxies support is now complete in V8. The tests needed slight modification to match the spec implementation. PR-URL: nodejs#4722 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
PR-URL: nodejs#4722 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
4 tasks
|
@nodejs/build: Is there anything I can do to get the CI working? (see here) I am guessing I missed a ticky box somewhere, and I don't know what to do about it now. |
|
@ofrobots you need to check the box |
|
Rubberstamp LGTM. Some of the commit log status lines are overlong but most can probably be fixed with a s/usage/use/. |
PR-URL: nodejs#4722 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
PR-URL: nodejs#4722 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
PR-URL: nodejs#5159 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
PR-URL: nodejs#5159 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
PR-URL: nodejs#5159 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
PR-URL: nodejs#5159 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
PR-URL: nodejs#5159 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
PR-URL: nodejs#5159 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
PR-URL: nodejs#5159 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
PR-URL: nodejs#5159 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
PR-URL: nodejs#5159 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
PR-URL: nodejs#5159 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
PR-URL: nodejs#5159 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
PR-URL: nodejs#5204 Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: indutny - Fedor Indutny <fedor.indutny@gmail.com>
PR-URL: nodejs#5204 Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: indutny - Fedor Indutny <fedor.indutny@gmail.com>
Dynamic checks that CallbackInfo holds an ArrayBuffer handle can be converted into compiler enforced checks. Removed unused code, and other minor cleanup. PR-URL: nodejs#5204 Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: indutny - Fedor Indutny <fedor.indutny@gmail.com>
Old style SetWeak is now deprecated, and weakness now works like phantom references. This means we no longer have a reference to the object in the weak callback. We use a kInternalFields style weak callback which provides us with the contents of 2 internal fields where we can squirrel away the native buffer pointer. We can no longer neuter the buffer in the weak callback, but that should be unnecessary as the object is going to be GC'd during the current gc cycle. PR-URL: nodejs#5204 Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: indutny - Fedor Indutny <fedor.indutny@gmail.com>
Cleanup how node_contextify keeps weak references in order to prepare for new style phantom weakness API. We didn't need to keep a weak reference to the context's global proxy, as the context holds it. PR-URL: nodejs#5392 Reviewed-By: Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
Simplify how node_contextify was keeping a weak reference to the sandbox object in order to prepare for new style phantom weakness V8 API. It is simpler (and more robust) for the context to hold a reference to the sandbox in an embedder data field. Doing otherwise meant that the sandbox could become weak while the context was still alive. This wasn't a problem because we would make the reference strong at that point. Since the sandbox must live at least as long as the context, it would be better for the context to hold onto the sandbox. PR-URL: nodejs#5392 Reviewed-By: Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
PR-URL: nodejs#5392 Reviewed-By: Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
PR-URL: nodejs#5392 Reviewed-By: Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
V8 String::NewExternal is deprecated in 4.9. Migrate string_bytes.cc to the alternatives. PR-URL: nodejs#5462 Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
Migrate node_object_wrap.h to the new SetWeak API. PR-URL: nodejs#5494 Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: targos - Michaël Zasso <mic.besace@gmail.com>
Errors during build-addons were being silently ignored. PR-URL: nodejs#5494 Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: targos - Michaël Zasso <mic.besace@gmail.com>
Avoid 'delete this' as it can be hazardous and/or dependent on implementations. PR-URL: nodejs#5494 Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: targos - Michaël Zasso <mic.besace@gmail.com>
Pick up the latest known good release from the V8 4.9 branch: 4.9.385.27. V8 Commits: v8/v8@4.9.385.18...4.9.385.27 PR-URL: nodejs#5494 Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: targos - Michaël Zasso <mic.besace@gmail.com>
PR-URL: nodejs#5159 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
PR-URL: nodejs#4722 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
|
Fixed the overlong commit log status lines. |
|
LGTM |
|
Landed as 8938355...ad0ce57. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
V8 4.9 is now stable with launch of Chrome 49 as stable: http://googlechromereleases.blogspot.com/2016/03/stable-channel-update.html
This PR picks up
vee-eight-4.9as a rebase overmaster. There are no new commits over #5494.V8 4.9 brings us up to 91% ES6 support including Destructuring, Proxies and Reflect, Default Parameters, Classes & lexical declarations in sloppy mode, sticky flag on Regular Expressions, customizable Object.prototype.toString output and more. For full details, see: http://v8project.blogspot.de/2016/01/v8-release-49.html
R=@nodejs/v8
CI: https://ci.nodejs.org/job/node-test-pull-request/1826/CI: https://ci.nodejs.org/job/node-test-pull-request/1828/