test_runner: consider --enable-source-maps option in coverage report

[geeksilva97]

Ref: #54753

[nodejs-github-bot]

Review requested:

• @nodejs/test_runner

[RedYetiDev]

Just FYI there's some logic issues that need to resolved for this (see #55106 and #55039)

[RedYetiDev]

Don't use getOptionValue. Instead, check whether the test runners sourceMaps is true.

[geeksilva97]

@RedYetiDev , do you have any clue on how I could do that?

[RedYetiDev]

See my previous implementation for more information

[RedYetiDev]

This was tried in #55039, however it couldn't land until a regression was fixed.

IMHO this PR will have the same result. Maybe looking into-and fixing?-the regression will help this move along?

[geeksilva97]

This was tried in #55039, however it couldn't land until a regression was fixed.

IMHO this PR will have the same result. Maybe looking into-and fixing?-the regression will help this move along?

Thanks for letting me know. Let me close this then and look into this regression stuff.

[codecov]

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.24%. Comparing base (17fd327) to head (ec3a30a).
Report is 17 commits behind head on main.

Files with missing lines	Patch %	Lines
lib/internal/test_runner/coverage.js	66.66%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #55146      +/-   ##
==========================================
- Coverage   88.25%   88.24%   -0.01%     
==========================================
  Files         651      651              
  Lines      183915   183900      -15     
  Branches    35867    35857      -10     
==========================================
- Hits       162307   162276      -31     
- Misses      14895    14910      +15     
- Partials     6713     6714       +1     

Files with missing lines	Coverage Δ
lib/internal/test_runner/coverage.js	64.70% <66.66%> (-0.05%)	⬇️

... and 47 files with indirect coverage changes

[geeksilva97]

@RedYetiDev I had started some implementation related to non-mapped lines in that same issue.

Following @jaydenseric's suggestion it worked.

ℹ -----------------------------------------------------------
ℹ file       | line % | branch % | funcs % | uncovered lines
ℹ -----------------------------------------------------------
ℹ a.mts      | 100.00 |   100.00 |  100.00 |
ℹ test.mjs   | 100.00 |   100.00 |  100.00 |
ℹ -----------------------------------------------------------
ℹ all files  | 100.00 |   100.00 |  100.00 |
ℹ -----------------------------------------------------------

Is it worth opening a PR or does it also depend on regression?

[RedYetiDev]

Feel free to open a PR. Only --enable-source-maps has the regression