Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: fix typos #55061

Merged
merged 8 commits into from
Oct 15, 2024
Merged
Show file tree
Hide file tree
Changes from 7 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tools/actions/commit-queue.sh
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ for pr in "$@"; do
fi

git node land --autorebase --yes $MULTIPLE_COMMIT_POLICY "$pr" >output 2>&1 || echo "Failed to land #${pr}"
# cat here otherwise we'll be supressing the output of git node land
# cat here otherwise we'll be suppressing the output of git node land
cat output

# TODO(mmarchini): workaround for ncu not returning the expected status code,
Expand Down
4 changes: 2 additions & 2 deletions tools/dep_updaters/utils.sh
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
ROOT=$(cd "$(dirname "$0")/../.." && pwd)
export ROOT

# This function compare new version with current version of a depdendency and
# This function compare new version with current version of a dependency and
# exit the script if the versions are the same
#
# $1 is the package name e.g. 'acorn', 'ada', 'base64' etc. See the file
Expand Down Expand Up @@ -55,7 +55,7 @@ finalize_version_update() {
# https://github.com/nodejs/node/blob/main/doc/contributing/maintaining/maintaining-dependencies.md
# for a complete list of package name
# $2 is the downloaded archive
# $3 (optional) is the deposited sha256 cheksum. When provided, it is checked
# $3 (optional) is the deposited sha256 checksum. When provided, it is checked
# against the checksum generated from the archive
log_and_verify_sha256sum() {
package_name="$1"
Expand Down
2 changes: 1 addition & 1 deletion tools/gen_node_def.cc
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
// symbols from the DLL and redirects them back to the DLL.
// This allows node.exe to export the same symbols as libnode.dll
// when building Node.js as a shared library. This is conceptually
// similary to the create_expfile.sh script used on AIX.
// similarly to the create_expfile.sh script used on AIX.
NathanBaulch marked this conversation as resolved.
Show resolved Hide resolved
//
// Generating this .def file requires parsing data out of the
// PE32/PE32+ file format. Helper structs are defined in <Windows.h>
Expand Down
4 changes: 2 additions & 2 deletions tools/gypi_to_gn.py
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
in GYP down requires a level of indirection. Any calls will have to be removed
and cleaned up once the GYP-to-GN transition is complete.
As a result, we only use this script when the list of files is large and
frequently-changing. In these cases, having one canonical list outweights the
frequently-changing. In these cases, having one canonical list outweighs the
downsides.
As of this writing, the GN build is basically complete. It's likely that all
large and frequently changing targets where this is appropriate use this
Expand Down Expand Up @@ -253,7 +253,7 @@ def LoadPythonDictionary(path):

def ReplaceSubstrings(values, search_for, replace_with):
"""Recursively replaces substrings in a value.
Replaces all substrings of the "search_for" with "repace_with" for all
Replaces all substrings of the "search_for" with "replace_with" for all
strings occurring in "values". This is done by recursively iterating into
lists as well as the keys and values of dictionaries."""
if isinstance(values, str):
Expand Down
2 changes: 1 addition & 1 deletion tools/msvs/vswhere_usability_wrapper.cmd
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ if "%~3"=="prerelease" set VSWHERE_WITH_PRERELEASE=1
set "InstallerPath=%ProgramFiles(x86)%\Microsoft Visual Studio\Installer"
if not exist "%InstallerPath%" set "InstallerPath=%ProgramFiles%\Microsoft Visual Studio\Installer"
if not exist "%InstallerPath%" goto :no-vswhere
:: Manipulate %Path% for easier " handeling
:: Manipulate %Path% for easier " handling
set "Path=%Path%;%InstallerPath%"
where vswhere 2> nul > nul
if errorlevel 1 goto :no-vswhere
Expand Down
2 changes: 1 addition & 1 deletion tools/pseudo-tty.py
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ def pipe(sfd, dfd):
if __name__ == '__main__':
argv = sys.argv[1:]

# Make select() interruptable by SIGCHLD.
# Make select() interruptible by SIGCHLD.
signal.signal(signal.SIGCHLD, lambda nr, _: None)

parent_fd, child_fd = pty.openpty()
Expand Down
2 changes: 1 addition & 1 deletion tools/v8_gypfiles/features.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@
# Enable third party HEAP library
'v8_enable_third_party_heap%': 0,

# Libaries used by third party heap
# Libraries used by third party heap
'v8_third_party_heap_libs%': [],

# Source code used by third party heap
Expand Down
2 changes: 1 addition & 1 deletion tools/v8_gypfiles/inspector.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@
# Flat merge `third_party/inspector_protocol:inspector_string_conversions`
'<(inspector_path)/v8-string-conversions.cc',
'<(inspector_path)/v8-string-conversions.h',
# Flat merge `third_party/inspector_protocal:crdtp_platform`
# Flat merge `third_party/inspector_protocol:crdtp_platform`
'<(inspector_protocol_path)/crdtp/json_platform.h',
'<(inspector_protocol_path)/crdtp/json_platform_v8.cc',
# Flat merge `third_party/inspector_protocol:crdtp`
Expand Down
2 changes: 1 addition & 1 deletion tools/v8_gypfiles/v8.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -1893,7 +1893,7 @@
['enable_lto=="true"', {
'cflags_cc': [ '-fno-lto' ],
}],
# Chnges in push_registers_asm.cc in V8 v12.8 requires using
# Changes in push_registers_asm.cc in V8 v12.8 requires using
# push_registers_masm on Windows even with ClangCL on x64
['OS=="win"', {
'conditions': [
Expand Down
Loading