Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: update V8 to 13.0 #55014

Draft
wants to merge 16 commits into
base: main
Choose a base branch
from
Draft

deps: update V8 to 13.0 #55014

wants to merge 16 commits into from

Commits on Oct 2, 2024

  1. deps: update V8 to 13.0.245.13

    @targos
    targos committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    1ad85a2 View commit details
    Browse the repository at this point in the history

  2. build: reset embedder string to "-node.0"

    @targos
    targos committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    9f5ea88 View commit details
    Browse the repository at this point in the history

  3. src: update NODE_MODULE_VERSION to 132 

    Major V8 updates are usually API/ABI incompatible with previous
versions. This commit adapts NODE_MODULE_VERSION for V8 13.0.

Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md
    @targos
    targos committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    4cb7fc1 View commit details
    Browse the repository at this point in the history

  4. deps: always define V8_EXPORT_PRIVATE as no-op 

    dllexport introduces issues when compiling with MSVC.

PR-URL: nodejs#47251
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
    @targos
    targos committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    98ede7c View commit details
    Browse the repository at this point in the history

  5. deps: disable V8 concurrent sparkplug compilation 

    It introduces process hangs on some platforms because Node.js doesn't
tear down V8 correctly.
Disable it while we work on a solution.

Refs: nodejs#47297
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=13902
PR-URL: nodejs#47450
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @targos
    targos committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    11b0332 View commit details
    Browse the repository at this point in the history

  6. deps: patch V8 to avoid duplicated zlib symbol 

    PR-URL: nodejs#54077
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    @targos
    targos committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    a0a9f69 View commit details
    Browse the repository at this point in the history

  7. deps: patch V8 to support compilation with MSVC 

    Co-Authored-By: Michaël Zasso <targos@protonmail.com>
PR-URL: nodejs#54536
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
    @StefanStojanovic @targos
    StefanStojanovic and targos committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    c6a5957 View commit details
    Browse the repository at this point in the history

  8. deps: fix FP16 bitcasts.h 

    PR-URL: nodejs#53134
Refs: nodejs#52809
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @StefanStojanovic @targos
    StefanStojanovic authored and targos committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    e9c112f View commit details
    Browse the repository at this point in the history

  9. deps: always define V8_NODISCARD as no-op 

    It's causing compiler errors with some classes on Xcode 11
and the attribute should have no runtime effect.

PR-URL: nodejs#54077
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    @targos
    targos committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    9cbd677 View commit details
    Browse the repository at this point in the history

  10. deps: patch V8 to support older Clang versions 

    PR-URL: nodejs#54536
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
    @targos
    targos committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    e68b2f6 View commit details
    Browse the repository at this point in the history

  11. deps: V8: cherry-pick 0c11feeeca4a 

    Original commit message:

    [turboshaft][tsa] specify namespace for Block

    It is ambiguous otherwise. There is `v8::internal::Block` and
    `v8::internal::compiler::turboshaft::Block`.
    This change is also consistent with the other types used in the macro.

    Change-Id: Ica7e5a09de955d8f38756fe26ab5f7e93e7e16e2
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5878257
    Reviewed-by: Camillo Bruni <cbruni@chromium.org>
    Commit-Queue: Michaël Zasso <mic.besace@gmail.com>
    Reviewed-by: Igor Sheludko <ishell@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#96278}

Refs: v8/v8@0c11fee
    @targos
    targos committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    fa7c0ee View commit details
    Browse the repository at this point in the history

  12. tools: update V8 gypfiles for 13.0 

    Refs: v8/v8@568f50d
Refs: v8/v8@6437539
    @targos
    targos committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    ad7e6fa View commit details
    Browse the repository at this point in the history

  13. build: remove support for ppc 32-bit 

    V8 removed support for it.

Refs: v8/v8@6437539
    @targos
    targos committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    b38b960 View commit details
    Browse the repository at this point in the history

  14. src: update GetForegroundTaskRunner override 

    Refs: https://chromium-review.googlesource.com/c/v8/v8/+/5758110
    @targos
    Etienne Pierre-doray authored and targos committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    a2ca5ff View commit details
    Browse the repository at this point in the history

  15. build: link V8 with atomic library 

    Closes: nodejs/node-v8#290
    @targos
    targos committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    827685d View commit details
    Browse the repository at this point in the history

  16. test: disable fast API call count checks 

    It seems that the arguments are no longer of type `FastOneByteString`.
    @targos
    targos committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    141296a View commit details
    Browse the repository at this point in the history