Skip to content

Conversation

@avivkeller
Copy link
Member

@avivkeller avivkeller commented Sep 14, 2024

The test setup is incorrect:

it('should error on import', async () => {
  try {
    await import(fixtures.fileURL('es-modules/noext-wasm'));
    mustNotCall();
  } catch (err) {
    ok(err instanceof SyntaxError);
  }
});

In the correct setup, mustNotCall() should be invoked as mustNotCall()();. However, the test fails in this case, indicating that the import is actually successful. This PR fixes the invalid test.

@nodejs-github-bot nodejs-github-bot added esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Sep 14, 2024
@avivkeller avivkeller added loaders Issues and PRs related to ES module loaders esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. and removed esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. labels Sep 14, 2024
@avivkeller avivkeller changed the title test: remove invalid test test: fix invalid test Sep 14, 2024
@codecov
Copy link

codecov bot commented Sep 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.07%. Comparing base (75e4d0d) to head (b5aa5a6).
Report is 540 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #54935   +/-   ##
=======================================
  Coverage   88.06%   88.07%           
=======================================
  Files         651      651           
  Lines      183451   183451           
  Branches    35821    35827    +6     
=======================================
+ Hits       161564   161574   +10     
+ Misses      15133    15130    -3     
+ Partials     6754     6747    -7     

see 23 files with indirect coverage changes

@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 17, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 17, 2024
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@avivkeller avivkeller added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 18, 2024
@lpinca lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 20, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 20, 2024
@nodejs-github-bot nodejs-github-bot merged commit 2a1607c into nodejs:main Sep 20, 2024
@nodejs-github-bot
Copy link
Collaborator

Landed in 2a1607c

targos pushed a commit that referenced this pull request Oct 4, 2024
PR-URL: #54935
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@aduh95 aduh95 mentioned this pull request Oct 9, 2024
louwers pushed a commit to louwers/node that referenced this pull request Nov 2, 2024
PR-URL: nodejs#54935
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@marco-ippolito marco-ippolito added the dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. label Nov 16, 2024
tpoisseau pushed a commit to tpoisseau/node that referenced this pull request Nov 21, 2024
PR-URL: nodejs#54935
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. esm Issues and PRs related to the ECMAScript Modules implementation. loaders Issues and PRs related to ES module loaders needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants