Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add write flag when open file as the demo code's intention #54626

Merged
merged 1 commit into from
Nov 2, 2024

Conversation

robberfree
Copy link
Contributor

No description provided.

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem. labels Aug 29, 2024
@RedYetiDev
Copy link
Member

RedYetiDev commented Aug 29, 2024

Can you provide a bit more information about why this change is needed?

@robberfree
Copy link
Contributor Author

Hi @RedYetiDev, sorry for delay replying. The code show how to create one custom writeable stream: open one file then write data to it. So we must make sure open the file with "write" mode. Default mode is "read".

@RedYetiDev
Copy link
Member

RedYetiDev commented Sep 2, 2024

No worries! Thanks for the info.

@jakecastelli jakecastelli added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 24, 2024
@marco-ippolito marco-ippolito added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 2, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 2, 2024
@nodejs-github-bot nodejs-github-bot merged commit 7f6ea83 into nodejs:main Nov 2, 2024
28 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 7f6ea83

louwers pushed a commit to louwers/node that referenced this pull request Nov 2, 2024
PR-URL: nodejs#54626
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
aduh95 pushed a commit that referenced this pull request Nov 5, 2024
PR-URL: #54626
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
aduh95 pushed a commit that referenced this pull request Nov 6, 2024
PR-URL: #54626
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants