Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: V8: backport f320600cd1f4 (V20.x CVE-2024-4761) #54598

Open
wants to merge 3 commits into
base: v20.x-staging
Choose a base branch
from
Open

deps: V8: backport f320600cd1f4 (V20.x CVE-2024-4761) #54598

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
67b548b
deps: V8: backport f320600cd1f4
giancorderoortiz Aug 27, 2024
4658be2
V8 backport of f320600
giancorderoortiz Aug 27, 2024
c34a757
Fix pointer deference
giancorderoortiz Sep 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion common.gypi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@

# Reset this number to 0 on major V8 upgrades.
# Increment by one for each non-official patch applied to deps/v8.
'v8_embedder_string': '-node.23',
'v8_embedder_string': '-node.24',

##### V8 defaults for Node.js #####

Expand Down
4 changes: 1 addition & 3 deletions deps/v8/src/objects/js-objects.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -445,9 +445,7 @@ Maybe<bool> JSReceiver::SetOrCopyDataProperties(
Nothing<bool>());

if (!from->HasFastProperties() && target->HasFastProperties() &&
!target->IsJSGlobalProxy()) {
// JSProxy is always in slow-mode.
DCHECK(!target->IsJSProxy());
IsJSObject(*target) && !IsJSGlobalProxy(*target)) {
// Convert to slow properties if we're guaranteed to overflow the number of
// descriptors.
int source_length;
Expand Down
Loading