Merged
Conversation
Collaborator
|
Review requested:
|
Contributor
|
Fast-track has been requested by @RafaelGSS. Please 👍 to approve. |
nodejs-github-bot
added
doc
mertcanaltin
approved these changes
Aug 6, 2024
aduh95
approved these changes
Aug 6, 2024
aduh95
added
the
author ready
richardlau
approved these changes
Aug 6, 2024
marco-ippolito
approved these changes
Aug 6, 2024
aduh95
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/54229 ✔ Done loading data for nodejs/node/pull/54229 ----------------------------------- PR info ------------------------------------ Title doc: sort versions DESC (#54229) Author Rafael Gonzaga <rafael.nunu@hotmail.com> (@RafaelGSS) Branch RafaelGSS:hot-fix-lint -> nodejs:main Labels doc, fast-track, author ready, test_runner Commits 1 - doc: sort versions DESC Committers 1 - RafaelGSS <rafael.nunu@hotmail.com> PR-URL: https://github.com/nodejs/node/pull/54229 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/54229 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 06 Aug 2024 17:37:58 GMT ✔ Approvals: 3 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/54229#pullrequestreview-2221900184 ✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/54229#pullrequestreview-2221915913 ✔ - Marco Ippolito (@marco-ippolito) (TSC): https://github.com/nodejs/node/pull/54229#pullrequestreview-2221928659 ℹ This PR is being fast-tracked ✘ GitHub CI is still running ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/10272268514 |
richardlau
added
commit-queue
nodejs-github-bot
added
commit-queue-failed
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/54229 ✔ Done loading data for nodejs/node/pull/54229 ----------------------------------- PR info ------------------------------------ Title doc: sort versions DESC (#54229) Author Rafael Gonzaga <rafael.nunu@hotmail.com> (@RafaelGSS) Branch RafaelGSS:hot-fix-lint -> nodejs:main Labels doc, fast-track, author ready, test_runner Commits 1 - doc: sort versions DESC Committers 1 - RafaelGSS <rafael.nunu@hotmail.com> PR-URL: https://github.com/nodejs/node/pull/54229 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/54229 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 06 Aug 2024 17:37:58 GMT ✔ Approvals: 3 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/54229#pullrequestreview-2221900184 ✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/54229#pullrequestreview-2221915913 ✔ - Marco Ippolito (@marco-ippolito) (TSC): https://github.com/nodejs/node/pull/54229#pullrequestreview-2221928659 ℹ This PR is being fast-tracked ✘ GitHub CI is still running ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/10273388777 |
Contributor
|
Landed in 7327e44 |
targos
added
dont-land-on-v18.x
dont-land-on-v20.x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When resolving conflicts, I forgot about this lint rule we have.