Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http_parser: use MakeCallback #5419

Merged
merged 1 commit into from
Mar 1, 2016
Merged

Commits on Mar 1, 2016

  1. http_parser: use MakeCallback

    Make `HTTPParser` an instance of `AsyncWrap` and make it use
    `MakeCallback`. This means that async wrap hooks will be called on
    consumed TCP sockets as well as on non-consumed ones.
    
    Additional uses of `AsyncCallbackScope` are necessary to prevent
    improper state from progressing that triggers failure in the
    test-http-pipeline-flood.js test. Optimally this wouldn't be necessary,
    but for the time being it's the most sure way to allow operations to
    proceed as they have.
    
    Fix: nodejs#4416
    PR-URL: nodejs#5419
    Reviewed-By: Fedor Indutny <fedor@indutny.com>
    trevnorris committed Mar 1, 2016
    Configuration menu
    Copy the full SHA
    a7e49c8 View commit details
    Browse the repository at this point in the history