Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix test-cli-permission tests when cwd contains /tmp #54188

Merged
merged 2 commits into from
Aug 14, 2024
Merged

test: fix test-cli-permission tests when cwd contains /tmp #54188

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
effea4b
test: use relative paths in test-cli-permission tests
sendoru Aug 3, 2024
615b1b7
test: skip the last test case when `/tmp` is `firstPath`
sendoru Aug 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
test: skip the last test case when /tmp is firstPath 
Differing from the other subdirectories of `/` `/tmp` has rwx
permissions for all users. In the case where `firstPath` is `/tmp`,
the last test case will fail, as it expects granting permission to
`firstPath` will be failed. This commit skips the last test case when
`firstPath` is `/tmp`.

Fixes: #54021
  • Loading branch information
@sendoru
sendoru committed Aug 3, 2024
commit 615b1b7143864dc74f3966052e256c611551eabf
3 changes: 3 additions & 0 deletions test/parallel/test-cli-permission-deny-fs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,9 @@ const path = require('path');
if (firstPath.startsWith('/etc')) {
common.skip('/etc as firstPath');
}
if (firstPath.startsWith('/tmp')) {
common.skip('/tmp as firstPath');
}
const file = fixtures.path('permission', 'loader', 'index.js');
const { status, stderr } = spawnSync(
process.execPath,
Expand Down
Loading