Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: add --without-amaro build flag #54136

Merged
merged 3 commits into from
Aug 2, 2024
Merged

build: add --without-amaro build flag #54136

merged 3 commits into from
Aug 2, 2024

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Jul 31, 2024

With ./configure --without-amaro, the resulting node binary won't contain the Amaro source (which includes the SWC WASM binary). This PR does not remove the --experimental-strip-types CLI flag, when using this flag an error will be emitted when trying to load a module-typescript or commonjs-typescript module.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/gyp

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Jul 31, 2024
@marco-ippolito
Copy link
Member

should the flag be added to the vcbuild.bat too?

@codecov Codecov
Copy link

codecov bot commented Jul 31, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.07%. Comparing base (b4fd1fd) to head (c178ac4).
Report is 529 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #54136   +/-   ##
=======================================
  Coverage   87.06%   87.07%           
=======================================
  Files         643      643           
  Lines      181576   181576           
  Branches    34894    34891    -3     
=======================================
+ Hits       158088   158106   +18     
+ Misses      16759    16753    -6     
+ Partials     6729     6717   -12
Files with missing lines Coverage Δ
src/node_metadata.cc 96.42% <ø> (ø)

... and 31 files with indirect coverage changes

@marco-ippolito marco-ippolito added the strip-types Issues or PRs related to strip-types support label Jul 31, 2024
@aduh95
Copy link
Contributor Author

aduh95 commented Jul 31, 2024

should the flag be added to the vcbuild.bat too?

Not my area of expertise, and no way for me to test it, but I'd say no based on the fact that HAVE_OPENSSL and node_use_openssl are not defined in vcbuild.bat

@aduh95 aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 31, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 31, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60769/

marco-ippolito
marco-ippolito approved these changes Jul 31, 2024
View reviewed changes
Copy link
Member

@marco-ippolito marco-ippolito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60808/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60811/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60827/

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Aug 2, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 2, 2024
@nodejs-github-bot nodejs-github-bot merged commit 1e3a347 into nodejs:main Aug 2, 2024
62 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 1e3a347

@aduh95 aduh95 deleted the without-amaro-build-flag branch August 2, 2024 12:04
targos pushed a commit that referenced this pull request Aug 14, 2024
@aduh95 @targos
build: add --without-amaro build flag
98fed76 
PR-URL: #54136
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Aug 19, 2024
Merged
@targos targos added the dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. label Sep 21, 2024
@zcbenz zcbenz mentioned this pull request Nov 9, 2024
Merged
nodejs-github-bot pushed a commit that referenced this pull request Nov 11, 2024
@zcbenz
build: implement node_use_amaro flag in GN build
57f23b4 
PR-URL: #55798
Refs: #54136
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marco-ippolito marco-ippolito marco-ippolito approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

@anonrig anonrig anonrig approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. strip-types Issues or PRs related to strip-types support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@aduh95 @nodejs-github-bot @marco-ippolito @anonrig @RafaelGSS @targos