test_runner: refactoring for supporting in-process testing#53921
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom Jul 20, 2024
Merged
test_runner: refactoring for supporting in-process testing#53921nodejs-github-bot merged 1 commit intonodejs:mainfrom
nodejs-github-bot merged 1 commit intonodejs:mainfrom
Conversation
This commit refactors some of the internals of the test runner.
Collaborator
|
Review requested:
|
nodejs-github-bot
added
needs-ci
atlowChemi
approved these changes
Jul 18, 2024
Member
atlowChemi
left a comment
atlowChemi
left a comment
There was a problem hiding this comment.
LGTM, but shouldn't the change in the order of before hook be considered a breaking change? (hence semver-major)
Contributor
Author
|
@atlowChemi I have backed out that change for now. I think it may be fine for the purposes of test isolation. I do think it is a minor bug though. We have an |
MoLow
approved these changes
Jul 18, 2024
github-actions
bot
removed
the
request-ci
Collaborator
benjamingr
approved these changes
Jul 18, 2024
Collaborator
jasnell
approved these changes
Jul 19, 2024
Collaborator
Collaborator
cjihrig
added
author ready
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in dab12a2 |
targos
pushed a commit
that referenced
this pull request
Jul 28, 2024
This commit refactors some of the internals of the test runner. PR-URL: #53921 Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
targos
added
the
dont-land-on-v20.x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hopefully this is the last bit of refactoring before adding support for running multiple test files in the same process.