github: put description of PR to the end of tmpl #5378
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like github appends commit log right after the template contents. Seeing this it does not look logical to ask for details first. This commit puts `Description of change` part to the end of the template.
|
cc @nodejs/collaborators @Fishrock123 @mscdex and all others. |
indutny
added
the
meta
|
Now that I can see it rendered, can this line be moved to the end of the previous line? |
|
@mscdex it will go over 80 columns, perhaps I should move |
|
@mscdex hopefully, ack |
|
LGTM. Perhaps in a separate PR I'd like to not that checklist items that do not apply can be removed. (i.e. doc changes, example: #5391) |
|
Landed in 4bd8b20, thank you! Please feel free to open follow-up PR. |
indutny
deleted the
feature/follow-up-to-81e35b5a2956604a6a3b9bb795a74a342702cc12
branch
indutny
added a commit
that referenced
this pull request
Feb 24, 2016
It looks like github appends commit log right after the template contents. Seeing this it does not look logical to ask for details first. This commit puts `Description of change` part to the end of the template. PR-URL: #5378 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
rvagg
pushed a commit
that referenced
this pull request
Feb 27, 2016
It looks like github appends commit log right after the template contents. Seeing this it does not look logical to ask for details first. This commit puts `Description of change` part to the end of the template. PR-URL: #5378 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
make -j8 test(UNIX) orvcbuild test nosign(Windows) pass withthis change (including linting)?
test (or a benchmark) included?
existing APIs, or introduces new ones)?
NOTE: these things are not required to open a PR and can be done afterwards /
while the PR is open.
Affected core subsystem(s)
Please provide affected core subsystem(s) (like buffer, cluster, crypto, etc)
Description of change
It looks like github appends commit log right after the template
contents. Seeing this it does not look logical to ask for details first.
This commit puts
Description of changepart to the end of thetemplate.
NOTE: I had to manually re-order this to put Description of change to the bottom in this PR