stream: update doc for new default high water mark #53494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
|
Thanks for submitting this change. Before this can be merged, the first commit message must be all lowercase to abide by the guidelines |
jsk95
changed the title
MoLow
previously approved these changes
Jun 18, 2024
Co-authored-by: jakecastelli <38635403+jakecastelli@users.noreply.github.com>
MoLow
reviewed
Jun 18, 2024
|
I think I made a wrong suggestion. It is not 16 KiB, |
MoLow
approved these changes
Jun 18, 2024
marco-ippolito
approved these changes
Jun 18, 2024
lpinca
approved these changes
Jun 18, 2024
trivikr
approved these changes
Jun 20, 2024
ronag
approved these changes
Jun 20, 2024
|
Thanks! Please merge whenever suits 👍 |
marco-ippolito
added
author ready
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/53494 ✔ Done loading data for nodejs/node/pull/53494 ----------------------------------- PR info ------------------------------------ Title stream: update doc for new default high water mark (#53494) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch jsk95:patch-1 -> nodejs:main Labels doc, stream, author ready Commits 3 - stream: update outdated highwatermark doc - stream: update doc for new default high water mark - stream: update outdated highwatermark doc Committers 2 - Jay Kim - GitHub PR-URL: https://github.com/nodejs/node/pull/53494 Reviewed-By: Moshe Atlow Reviewed-By: Marco Ippolito Reviewed-By: Luigi Pinca Reviewed-By: Trivikram Kamat Reviewed-By: Robert Nagy ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/53494 Reviewed-By: Moshe Atlow Reviewed-By: Marco Ippolito Reviewed-By: Luigi Pinca Reviewed-By: Trivikram Kamat Reviewed-By: Robert Nagy -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 17 Jun 2024 22:30:04 GMT ✔ Approvals: 5 ✔ - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/53494#pullrequestreview-2124683767 ✔ - Marco Ippolito (@marco-ippolito) (TSC): https://github.com/nodejs/node/pull/53494#pullrequestreview-2124771913 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/53494#pullrequestreview-2126027541 ✔ - Trivikram Kamat (@trivikr): https://github.com/nodejs/node/pull/53494#pullrequestreview-2129323141 ✔ - Robert Nagy (@ronag) (TSC): https://github.com/nodejs/node/pull/53494#pullrequestreview-2129414408 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 53494 From https://github.com/nodejs/node * branch refs/pull/53494/merge -> FETCH_HEAD ✔ Fetched commits as 399eb338f18a..222ea9835c4d -------------------------------------------------------------------------------- [main 670aaccf69] stream: update outdated highwatermark doc Author: Jay Kim Date: Tue Jun 18 15:04:52 2024 +1200 1 file changed, 1 insertion(+), 1 deletion(-) [main 15c4458804] stream: update doc for new default high water mark Author: Jay Kim <48934750+jsk95@users.noreply.github.com> Date: Tue Jun 18 18:09:46 2024 +1200 1 file changed, 1 insertion(+), 1 deletion(-) [main 6b2c590782] stream: update outdated highwatermark doc Author: Jay Kim Date: Tue Jun 18 18:39:43 2024 +1200 1 file changed, 1 insertion(+), 1 deletion(-) ✔ Patches applied There are 3 commits in the PR. Attempting autorebase. Rebasing (2/6)https://github.com/nodejs/node/actions/runs/9593864985 |
marco-ippolito
added
commit-queue-rebase
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/53494 ✔ Done loading data for nodejs/node/pull/53494 ----------------------------------- PR info ------------------------------------ Title stream: update doc for new default high water mark (#53494) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch jsk95:patch-1 -> nodejs:main Labels doc, stream, author ready, commit-queue-rebase Commits 3 - stream: update outdated highwatermark doc - stream: update doc for new default high water mark - stream: update outdated highwatermark doc Committers 2 - Jay Kim - GitHub PR-URL: https://github.com/nodejs/node/pull/53494 Reviewed-By: Moshe Atlow Reviewed-By: Marco Ippolito Reviewed-By: Luigi Pinca Reviewed-By: Trivikram Kamat Reviewed-By: Robert Nagy ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/53494 Reviewed-By: Moshe Atlow Reviewed-By: Marco Ippolito Reviewed-By: Luigi Pinca Reviewed-By: Trivikram Kamat Reviewed-By: Robert Nagy -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 17 Jun 2024 22:30:04 GMT ✔ Approvals: 5 ✔ - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/53494#pullrequestreview-2124683767 ✔ - Marco Ippolito (@marco-ippolito) (TSC): https://github.com/nodejs/node/pull/53494#pullrequestreview-2124771913 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/53494#pullrequestreview-2126027541 ✔ - Trivikram Kamat (@trivikr): https://github.com/nodejs/node/pull/53494#pullrequestreview-2129323141 ✔ - Robert Nagy (@ronag) (TSC): https://github.com/nodejs/node/pull/53494#pullrequestreview-2129414408 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 53494 From https://github.com/nodejs/node * branch refs/pull/53494/merge -> FETCH_HEAD ✔ Fetched commits as 399eb338f18a..222ea9835c4d -------------------------------------------------------------------------------- [main 193d49f831] stream: update outdated highwatermark doc Author: Jay Kim Date: Tue Jun 18 15:04:52 2024 +1200 1 file changed, 1 insertion(+), 1 deletion(-) [main c5477b4ef0] stream: update doc for new default high water mark Author: Jay Kim <48934750+jsk95@users.noreply.github.com> Date: Tue Jun 18 18:09:46 2024 +1200 1 file changed, 1 insertion(+), 1 deletion(-) [main eff494e913] stream: update outdated highwatermark doc Author: Jay Kim Date: Tue Jun 18 18:39:43 2024 +1200 1 file changed, 1 insertion(+), 1 deletion(-) ✔ Patches applied There are 3 commits in the PR. Attempting autorebase. Rebasing (2/6)https://github.com/nodejs/node/actions/runs/9594048048 |
MoLow
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in b952ee1 |
targos
pushed a commit
that referenced
this pull request
Jun 20, 2024
PR-URL: #53494 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com>
eliphazbouye
pushed a commit
to eliphazbouye/node
that referenced
this pull request
Jun 20, 2024
PR-URL: nodejs#53494 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com>
bmeck
pushed a commit
to bmeck/node
that referenced
this pull request
Jun 22, 2024
PR-URL: nodejs#53494 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com>
marco-ippolito
pushed a commit
that referenced
this pull request
Jul 19, 2024
PR-URL: #53494 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com>
marco-ippolito
pushed a commit
that referenced
this pull request
Jul 19, 2024
PR-URL: #53494 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New value for
stream.getDefaultHighWaterMark(objectMode)update was missed in the previous PR.#52037
Updating the value.