Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: replace deprecated GetImportAssertions V8 API #52997

Merged
merged 1 commit into from
May 18, 2024
Merged

src: replace deprecated GetImportAssertions V8 API #52997

merged 1 commit into from
May 18, 2024

Conversation

targos
Copy link
Member

@targos targos commented May 15, 2024

Use GetImportAttributes instead.

@targos
src: replace deprecated GetImportAssertions V8 API
d1efc0a 
Use `GetImportAttributes` instead.
@targos targos added dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. labels May 15, 2024
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels May 15, 2024
@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. label May 15, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 15, 2024
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59235/

@targos targos added the commit-queue Add this label to land a pull request using GitHub Actions. label May 18, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 18, 2024
@nodejs-github-bot nodejs-github-bot merged commit 37960ff into nodejs:main May 18, 2024
69 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 37960ff

targos added a commit that referenced this pull request May 21, 2024
@targos
src: replace deprecated GetImportAssertions V8 API
f1890ab 
Use `GetImportAttributes` instead.

PR-URL: #52997
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Jun 7, 2024
Merged
@targos targos deleted the GetImportAttributes branch June 10, 2024 09:45
eliphazbouye pushed a commit to eliphazbouye/node that referenced this pull request Jun 20, 2024
@targos @eliphazbouye
src: replace deprecated GetImportAssertions V8 API
ece9501 
Use `GetImportAttributes` instead.

PR-URL: nodejs#52997
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
bmeck pushed a commit to bmeck/node that referenced this pull request Jun 22, 2024
@targos @bmeck
src: replace deprecated GetImportAssertions V8 API
b5a3c5a 
Use `GetImportAttributes` instead.

PR-URL: nodejs#52997
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atlowChemi atlowChemi atlowChemi approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@targos @nodejs-github-bot @lpinca @atlowChemi