Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: specify that preloaded modules affect subprocesses #52939

Merged
merged 1 commit into from
Sep 4, 2024
Merged

doc: specify that preloaded modules affect subprocesses #52939

merged 1 commit into from
Sep 4, 2024

Conversation

RedYetiDev
Copy link
Member

Fixes #52930

Marking author as Co-Author, as they specified where the preloaded modules will appear.

@RedYetiDev @timfish
doc: specify that preloaded modules affect subprocesses
220e29a 
Co-Authored-By: Tim Fish <tim@timfish.uk>
@nodejs-github-bot nodejs-github-bot added cli Issues and PRs related to the Node.js command line interface. doc Issues and PRs related to the documentations. labels May 10, 2024
@RedYetiDev RedYetiDev added the loaders Issues and PRs related to ES module loaders label Jun 2, 2024
@RedYetiDev RedYetiDev added the review wanted PRs that need reviews. label Aug 9, 2024
@RedYetiDev
Copy link
Member Author

Hey, this hasn't seen any reviews or objections, just bumping it a bit.

@RedYetiDev
Copy link
Member Author

RedYetiDev commented Aug 19, 2024 •
edited
Loading

@jasnell I think this is good to land?

@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 4, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 4, 2024
@nodejs-github-bot nodejs-github-bot merged commit 2bd6a57 into nodejs:main Sep 4, 2024
30 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 2bd6a57

aduh95 pushed a commit that referenced this pull request Sep 12, 2024
@RedYetiDev @timfish @aduh95
doc: specify that preloaded modules affect subprocesses
de225f5 
Co-Authored-By: Tim Fish <tim@timfish.uk>
PR-URL: #52939
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Sep 16, 2024
Merged
@targos targos added the dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. label Sep 22, 2024
louwers pushed a commit to louwers/node that referenced this pull request Nov 2, 2024
@RedYetiDev @timfish @louwers
doc: specify that preloaded modules affect subprocesses
28f329f 
Co-Authored-By: Tim Fish <tim@timfish.uk>
PR-URL: nodejs#52939
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
cli Issues and PRs related to the Node.js command line interface. doc Issues and PRs related to the documentations. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. loaders Issues and PRs related to ES module loaders review wanted PRs that need reviews.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document more clearly that --require and --import can impact all threads and forked processes
5 participants
@RedYetiDev @nodejs-github-bot @jasnell @Trott @targos